kvs.h add extern "C" wrapper #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unnecessary includes from kvs.h.
Add extern "C" for C++ code. Was missed from a recent PR as mentioned in issue #1224.
|
Restarted one builder that failed with the "write error" issue. |
Codecov Report
@@ Coverage Diff @@
## master #1225 +/- ##
=========================================
Coverage ? 78.23%
=========================================
Files ? 158
Lines ? 29297
Branches ? 0
=========================================
Hits ? 22921
Misses ? 6376
Partials ? 0 |
|
Ok, took a few tries but the final build was successful, so merging! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing extern "C" wrapper in kvs.h from issue #1223 PR, as mentioned in issue #1224.