Misc KVS cleanup & minor fixes #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup cache tests, placing tests in functions to make clear tests being performed.
Remove unnecessary parameters passed to check() and check_stall() functions. The inputs are always the same, so they can be abstracted away.
Remove unnecessary/unused parameter in load() function.
Add several corner case checks and add unit tests to increase coverage.
When input is bad or not appropriate, return -1 in cache_entry_set_dirty() and cache_entry_set_json(). Add/update unit tests appropriately.
|
All looks pretty reasonable to me. |
|
hit #1169, restarting a run |
|
I'll check back later and merge this if it's green. (Have to duck out) |
Codecov Report
@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
- Coverage 78.25% 78.23% -0.03%
==========================================
Files 158 158
Lines 29139 29142 +3
==========================================
- Hits 22804 22800 -4
- Misses 6335 6342 +7
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling out these cleanup & minor fix patches from another patch series for #1187. Includes simple fixes (comments, code styles), minor cleanup (putting things in functions, removing unused parameters in function calls), some corner case fixes, and returning error on bad inputs to some functions.