-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libflux/flog: Support output to stderr #1192
Conversation
I think primary review is on format of output:
No colon? Upper case priority level string? I elected on colon and lower case. |
Looks good! Don't forget a mention in flux_log(3). |
Changes Unknown when pulling 7fd9a3b on chu11:issue1191 into ** on flux-framework:master**. |
Hmm, I had one build failure
Which suggests my test seg-faulted or something like that. hmmm. |
Sounds ok to me. |
Make flux handle optional in logging functions. If flux handle is NULL, output to stderr. Update documentation and add unit tests appropriately. Fixes flux-framework#1191
Codecov Report
@@ Coverage Diff @@
## master #1192 +/- ##
=========================================
Coverage ? 77.81%
=========================================
Files ? 158
Lines ? 29288
Branches ? 0
=========================================
Hits ? 22789
Misses ? 6499
Partials ? 0
|
Changes Unknown when pulling 670fbaa on chu11:issue1191 into ** on flux-framework:master**. |
pushed manpage updates & pushed fix for issue I listed above (failed chain lint was the issue). first run through travis hit #1169 and some write errors, restarting |
Thanks! Looks good. |
Make flux handle optional in logging functions. If flux handle
is NULL, output to stderr.
Add unit tests appropriately.
Fixes #1191