build: fix newer compiler warnings about enum passed to va_start #1184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change prototype of subprocess_manager_set() to avoid using an enum
as the argument passed to va_start(), as this causes warnings on newer
compilers which complain about
passing an object that undergoes default argument promotion
to 'va_start' has undefined behavior [-Werror,-Wvarargs]
The enum undergoes default promotion, and thus it may cause undefined
behavior. Therefore, change the enum argument to an integer to avoid
this warning.
Change prototype of optparse_get() and optparse_set() to avoid passing an enum as the argument to va_start() in these variadic functions. Use of enum causes newer compiler to issue warnings of the form: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs] Change the enum argument in these functions to an integer to suppress the warning and avoid potential undefined behavior.
|
Looks like this PR might turn into "fix travis-ci on latest trusty image" -- the libfaketime compile is also failing with the latest compilers so I'll have to fix that one here as well. |
Update to latest upstream version of libfaketime. Also, libfaketime doesn't appear to work with recent versions of clang. Force use of GCC.
grondo
force-pushed
the
va_start-avoid-enum
branch
from
aa28d71 to
d206431
Compare
Codecov Report
@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 77.82% 77.87% +0.05%
==========================================
Files 158 158
Lines 29255 29254 -1
==========================================
+ Hits 22767 22783 +16
+ Misses 6488 6471 -17
|
|
Thanks for running this down. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes newer compiler warnings that complain about passing default type promoted objects as an argument to
va_start. In both places this is done in the current code, an enum is passed as the last argument before the ellipsis in a variadic function, and I guess this could cause undefined behavior depending on how the enum is promoted.The fix for now is to simply change the argument to an integer.
This should fix current failures in travis, since the warning causes a fatal error with
-Werror