cmd/flux-start: Add input error check #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If user specifies --bootstrap=selfpmi but does not specify --size, output error message indicating it is needed. Add unit test to test for this particular failure. Fixes flux-framework#1026
|
Changes Unknown when pulling dbbc9da on chu11:issue1026 into ** on flux-framework:master**. |
Codecov Report
@@ Coverage Diff @@
## master #1168 +/- ##
=========================================
Coverage ? 77.68%
=========================================
Files ? 158
Lines ? 29089
Branches ? 0
=========================================
Hits ? 22598
Misses ? 6491
Partials ? 0
|
|
Thanks, looks good! Looks like coverage is reporting the baseline is missing for some reason. Well, there's clearly no coverage issue here so I'll go ahead and merge this and look at that separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user specifies --bootstrap=selfpmi but does not specify --size,
output error message indicating it is needed.
Add unit test to test for this particular failure.
Fixes #1026