Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in my name is now corrected #1164

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Typo in my name is now corrected #1164

merged 1 commit into from
Aug 25, 2017

Conversation

digitalresistor
Copy link
Contributor

It is by happenstance that I came across this, and I noticed the typo in my name. I'm glad that my blogging has been helpful!

It is by happenstance that I came across this, and I noticed the typo in my name. I'm glad that my blogging has been helpful!
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.007%) to 77.908% when pulling 9b9490c on bertjwregeer:patch-1 into e2b5e8d on flux-framework:master.

@digitalresistor
Copy link
Contributor Author

I'm somewhat enjoying the fact that correcting a typo in a comment leads to coverage decreasing and a failed travis build!

@codecov-io
Copy link

Codecov Report

Merging #1164 into master will decrease coverage by 0.15%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1164      +/-   ##
==========================================
- Coverage    77.7%   77.55%   -0.16%     
==========================================
  Files         158      158              
  Lines       28758    28757       -1     
==========================================
- Hits        22347    22303      -44     
- Misses       6411     6454      +43
Impacted Files Coverage Δ
src/common/libutil/ev_zmq.c 91.3% <ø> (ø) ⬆️
src/common/libflux/handle.c 83.16% <0%> (-3.22%) ⬇️
src/common/libcompat/handle.c 84.47% <0%> (-2.86%) ⬇️
src/common/libflux/info.c 75% <0%> (-2.78%) ⬇️
src/common/libcompat/info.c 65.82% <0%> (-2.54%) ⬇️
src/common/libkvs/jansson_dirent.c 64.44% <0%> (-2.23%) ⬇️
src/common/libkvs/kvs_watch.c 86.47% <0%> (-1.45%) ⬇️
src/common/libflux/response.c 83.73% <0%> (-0.82%) ⬇️
src/common/libkvs/kvs_txn.c 57.97% <0%> (-0.73%) ⬇️
src/broker/overlay.c 71.67% <0%> (-0.7%) ⬇️
... and 5 more

@garlick
Copy link
Member

garlick commented Aug 25, 2017

I'm somewhat enjoying the fact that correcting a typo in a comment leads to coverage decreasing and a failed travis build!

Well, if you had submitted an appropriate unit test...

Kidding! Thanks for that blog, it was indeed helpful, and my apologies for botching the spelling of your name!

@garlick garlick merged commit 53e3f12 into flux-framework:master Aug 25, 2017
@digitalresistor digitalresistor deleted the patch-1 branch August 25, 2017 15:45
@digitalresistor
Copy link
Contributor Author

No worries! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants