Misc Cleanup/Minor Fixes from KVS TreeObject Work #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit_basic_commit_process_test_multiple_fences(), make one of the commits in a directory vs the root dir, to mix up the workload.
Add missing function call to run some commit unit tests.
json_array_get() returns a borrowed reference, not a copy, so on error path the json object should not have its reference count decreased.
Remove cleanup on error path that is unnecessary. The item_callback_list in this particular area of code will always be empty if it has reached this particular error path.
Fix bug which error in watch callbacks was not detected and tests could still pass.
|
Changes Unknown when pulling 331763d on chu11:misccleanup7 into ** on flux-framework:master**. |
|
I restarted the clang build that failed with the "write error" problem (#1145) |
|
Looks good to me. Is 21947fc one that could go in this PR? |
Codecov Report
@@ Coverage Diff @@
## master #1152 +/- ##
========================================
Coverage ? 77.5%
========================================
Files ? 157
Lines ? 28755
Branches ? 0
========================================
Hits ? 22286
Misses ? 6469
Partials ? 0
|
|
fyi - codecov is complaining because the last coverage build on master failed. I kicked it, so that should be resolved in an hour or so. |
|
@garlick I skipped that one b/c the old code in master actually behaves incorrectly. So travis would fail. It'll all be corrected in the treeobj PR. |
|
OK, sounds good. I'll just go ahead and merge this without the updated coverage results since this touches very little code. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spliced out set of cleanup patches or minor bug fixes from TreeObject work both @garlick and I have been working on.
Note that @garlick has one patch in this PR, but it's only addition of a copyright header. Dunno if its safe for him to hit the button. But copyright header probably counts as "non-source documentation" (https://github.com/flux-framework/rfc/blob/master/spec_1.adoc).