connector/local: add exponential backoff to connect retry count #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the spellcheck tests are skipped (due to missing aspell for example), the skip TAP output is incorrect, or at least is deemed incorrect by the tap-driver.sh automake TAP driver, which causes the test to fail. Change the output to `1..0 # skip` to make the test driver happy.
Rename local connector retry count from FLUX_RETRY_COUNT to FLUX_LOCAL_CONNECTOR_RETRY_COUNT ass suggested in issue flux-framework#677.
Introduce an exponential backoff to the local connector's attempts to connect to the flux instance api domain socket. The backoff starts at 16ms and doubles up to 2s. This is so that the default retry count of 5 still times out after about 500ms as in the current code.
Allow more retries in flux_open in local connector as suggested in flux-framework#677.
|
Oh, oops I also added a fix for the spellcheck test, which isn't producing the |
Codecov Report
@@ Coverage Diff @@
## master #1148 +/- ##
==========================================
- Coverage 77.62% 77.56% -0.06%
==========================================
Files 157 157
Lines 28680 28694 +14
==========================================
- Hits 22262 22257 -5
- Misses 6418 6437 +19
|
|
Looks great, thanks! IMHO no big deal having the doc test fix in here also. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @garlick suggested in #677, add an exponential backoff to local connector connect retries, rename the variable to tune the retry count from
FLUX_RETRY_COUNTtoFLUX_LOCAL_CONNECTOR_RETRY_COUNT, and use this variable in t5000-valgrind.t to give up to 10 retries.I tried to make the the default retry count of 5 still time out after ~500ms, so I made the starting sleep 16ms, which should sleep a total of 496ms in the default cause -- unless in my haste I did some math wrong.