tmouthandler: should "oneshot" timer remove itself from reactor?

[grondo]

One might expect that a reactor loaded with one single shot timer should exit normally after
the timer is fired, for example, with the following lua code (not yet committed to a repo yet, sorry)

#!/usr/bin/lua
local f,err = require 'flux'.new()
if not f then error (err) end

local count = 0
local to, err = f:timer {
    timeout = 250,
    oneshot = true,
    handler = function (f, to)
            count = count + 1
        print (count)
    end
}
local r = f:reactor()
print ("exited from reactor with r="..r)

One would expect output like:

1
exited reactor with r=0

However, observed behavior is that the reactor hangs indefinitely after timer fires and requiresa ^C:

(flux-236991-0) grondo@hype356:~/git/flux-core.git/t/lua$ lua t.lua 
1
^Clua: t.lua:14: interrupted!
stack traceback:
        [C]: in function 'reactor'
        t.lua:14: in main chunk
        [C]: ?

Adding to:remove() to the timeout handler does rectify the issue, but it seems like it should be unecessary.

[garlick]

Agreed it should remove itself. Will fix.