shell: signal plugin fails to get job expiration and aborts job

[grondo]

On recent versions of flux, the --signal option, when used, causes jobs to abort immediately with an error about fetching the job expiration:

$ flux run --signal=USR1 hostname
1.671s: flux-shell[0]: ERROR: signal: unable to get job expiration: No such file or directory
1.671s: flux-shell[0]: ERROR: plugin 'signal': shell.init failed
1.677s: flux-shell[0]: FATAL: shell_init: No such file or directory
1.678s: job.exception type=exec severity=0 shell_init: No such file or directory

Somehow the tests in the testsuite are still working.

[grondo]

D'oh, this is the code that is failing:

    if (flux_shell_info_unpack (sig->shell,
                                "{s:{s:{s:f}}}",
                                "R",
                                "execution",
                                "expiration", &expiration) < 0) {
        shell_log_errno ("unable to get job expiration");
        return -1;
    }

Since Fluxion uses integers for expiration and starttime, the plugin should have used an F instead of f. 😞

[garlick]

Good catch!