Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

job-info: avoid error response on failed rpc #6498

Closed
chu11 opened this issue Dec 10, 2024 · 0 comments · Fixed by #6502
Closed

job-info: avoid error response on failed rpc #6498

chu11 opened this issue Dec 10, 2024 · 0 comments · Fixed by #6502
Assignees
@chu11

Comments

@chu11
Copy link
Member

chu11 commented Dec 10, 2024

similar to fixes in

0047178

need to do it in job-info, minimally in guest_watch.c
@chu11 chu11 self-assigned this Dec 12, 2024
chu11 added a commit to chu11/flux-core that referenced this issue Dec 12, 2024
@chu11
job-info: avoid error response on failed rpc
2354a68 
Problem: Common usage in flux-core is to not respond with an RPC error
(such as through flux_respond_error()) if a prior RPC attempt fails (such
as through flux_respond_pack()).  This pattern is violated in several
places in job-info.

Solution: If flux_respond_pack() fails, do not call flux_respond_error()
in error handling paths.

Fixes flux-framework#6498
@chu11 chu11 mentioned this issue Dec 12, 2024
Merged
@mergify mergify bot closed this as completed in #6502 Dec 13, 2024
@mergify mergify bot closed this as completed in 15aad44 Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

job-info: avoid error response on failed rpc chu11/flux-core
1 participant
@chu11