Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: add root sequence number to checkpoint object #4446

Closed
Tracked by #4428
garlick opened this issue Jul 29, 2022 · 0 comments · Fixed by #4475
Closed
Tracked by #4428

kvs: add root sequence number to checkpoint object #4446

garlick opened this issue Jul 29, 2022 · 0 comments · Fixed by #4475
Assignees

Comments

@garlick
Copy link
Member

garlick commented Jul 29, 2022

Problem: the KVS root sequence number, mentioned in #4311 as an indicator of how much change has been committed to the kvs, isn't persistent across restarts (e.g. it's not stored with the root hash in the checkpoint object). It therefore isn't a great indicator since it resets to zero whenever the instance restarts, whether a GC dump occurs across that reset or not.

Add the root sequence number to the checkpoint object. It should not be necessary to bump the checkpoint object version. We can just tolerate a missing sequence number when parsing and have it read as zero.

@chu11 chu11 self-assigned this Aug 5, 2022
chu11 added a commit to chu11/flux-core that referenced this issue Aug 8, 2022
Problem: The KVS root sequence number isn't persisted across
restarts.  It restarts at zero everytime the KVS module is loaded.

Solution: Add the root sequence number to the checkpoint object, read
it in and initialize the KVS primary namespace to that sequence
number.

Fixes flux-framework#4446
jameshcorbett pushed a commit to chu11/flux-core that referenced this issue Aug 8, 2022
Problem: The KVS root sequence number isn't persisted across
restarts.  It restarts at zero everytime the KVS module is loaded.

Solution: Add the root sequence number to the checkpoint object, read
it in and initialize the KVS primary namespace to that sequence
number.

Fixes flux-framework#4446
@mergify mergify bot closed this as completed in #4475 Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants