Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop unnecessary 0MQ includes #3624

Closed
garlick opened this issue Apr 29, 2021 · 0 comments · Fixed by #3782
Closed

drop unnecessary 0MQ includes #3624

garlick opened this issue Apr 29, 2021 · 0 comments · Fixed by #3782
Assignees
@chu11

Comments

@garlick
Copy link
Member

garlick commented Apr 29, 2021 •
edited by chu11
Loading

As noted in #3312 (#3617), we should try to minimize/localize our dependence on 0MQ libraries.

Problem: src/bindings/lua/zmsg-lua.h and src/cmd/builtin/proxy.c include [c]zmq.h unnecessarily.
@chu11 chu11 self-assigned this Jul 14, 2021
@chu11 chu11 mentioned this issue Jul 14, 2021
Closed
chu11 added a commit to chu11/flux-core that referenced this issue Jul 16, 2021
@chu11
Globally drop unnecessary 0MQ includes
48f7230 
Problem: czmq.h and/or zmq.h was included in a number of locations
that was unnecessary.

Solution: Remove the unnecessary includes.  In some cases, replace with
include of czmq_containers.h or other appropriate headers that czmq/zmq
happened to include.

Fixes flux-framework#3624
@chu11 chu11 mentioned this issue Jul 16, 2021
Merged
@mergify mergify bot closed this as completed in #3782 Jul 16, 2021
@chu11 chu11 mentioned this issue Jul 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Globally drop unnecessary 0MQ includes chu11/flux-core
2 participants
@garlick @chu11