-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use internal functions instead of czmq zdigest and zfile classes #3622
Comments
offline discussion w/ @garlick, perhaps |
chu11
added a commit
to chu11/flux-core
that referenced
this issue
May 6, 2021
Replace use of zfile with call to file_digest_str(). Fixes flux-framework#3622
chu11
added a commit
to chu11/flux-core
that referenced
this issue
May 6, 2021
Replace use of zfile with call to file_digest_str(). Fixes flux-framework#3622
chu11
added a commit
to chu11/flux-core
that referenced
this issue
May 8, 2021
Replace use of zfile with call to digest_file_str(). Fixes flux-framework#3622
chu11
added a commit
to chu11/flux-core
that referenced
this issue
May 8, 2021
Replace use of zfile with call to digest_file_str(). Fixes flux-framework#3622
chu11
added a commit
to chu11/flux-core
that referenced
this issue
May 8, 2021
Replace use of zfile with call to digest_file(). Fixes flux-framework#3622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Splitting off of #3617:
Problem: zdigest and zfile czmq classes are used in a couple of places in flux-core, but we have redundant functionaltiy "in house". Now that we have pulled in the czmq containers, we may want to stop using other classes so that we can disassociate ourselves from czmq at some point.
These classes are used in
t/kvs/hashtest.c
,t/module/parent.c
,src/cmd/flux-module.c
,src/broker/module.c
.zdigest computes the sha-1 digest for a buffer. We have
src/common/libutil/sha1.[ch]
.zfile is used in our code base to compute the sha-1 digest for a file. We have
src/common/libutil/read_all.[ch]
.The text was updated successfully, but these errors were encountered: