Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use internal functions instead of czmq zdigest and zfile classes #3622

Closed
garlick opened this issue Apr 29, 2021 · 2 comments
Closed

use internal functions instead of czmq zdigest and zfile classes #3622

garlick opened this issue Apr 29, 2021 · 2 comments
Assignees

Comments

@garlick
Copy link
Member

garlick commented Apr 29, 2021

Splitting off of #3617:

Problem: zdigest and zfile czmq classes are used in a couple of places in flux-core, but we have redundant functionaltiy "in house". Now that we have pulled in the czmq containers, we may want to stop using other classes so that we can disassociate ourselves from czmq at some point.

These classes are used in t/kvs/hashtest.c, t/module/parent.c, src/cmd/flux-module.c, src/broker/module.c.

zdigest computes the sha-1 digest for a buffer. We have src/common/libutil/sha1.[ch].

zfile is used in our code base to compute the sha-1 digest for a file. We have src/common/libutil/read_all.[ch].

@chu11
Copy link
Member

chu11 commented Apr 30, 2021

not sure you tagged the right issue, #3312 seems like the wrong one? did you mean #3617 (also in the other issues you opened)

@chu11 chu11 self-assigned this May 3, 2021
@chu11
Copy link
Member

chu11 commented May 4, 2021

offline discussion w/ @garlick, perhaps t/kvs/hashtest can just be removed. due to lack of configure support for hashtest's various options, most of it has not been used/tested in quite a long time.

chu11 added a commit to chu11/flux-core that referenced this issue May 6, 2021
Replace use of zfile with call to file_digest_str().

Fixes flux-framework#3622
chu11 added a commit to chu11/flux-core that referenced this issue May 6, 2021
Replace use of zfile with call to file_digest_str().

Fixes flux-framework#3622
chu11 added a commit to chu11/flux-core that referenced this issue May 8, 2021
Replace use of zfile with call to digest_file_str().

Fixes flux-framework#3622
chu11 added a commit to chu11/flux-core that referenced this issue May 8, 2021
Replace use of zfile with call to digest_file_str().

Fixes flux-framework#3622
chu11 added a commit to chu11/flux-core that referenced this issue May 8, 2021
Replace use of zfile with call to digest_file().

Fixes flux-framework#3622
@mergify mergify bot closed this as completed in d7d85e4 May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants