Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvs: flux_kvs_lookupat() should ignore namespace #1970

Closed
chu11 opened this issue Jan 29, 2019 · 1 comment
Closed

kvs: flux_kvs_lookupat() should ignore namespace #1970

chu11 opened this issue Jan 29, 2019 · 1 comment
Assignees
@chu11

Comments

@chu11
Copy link
Member

chu11 commented Jan 29, 2019

since it's given a root reference, a namespace isn't relevant.
@chu11
Copy link
Member Author

chu11 commented Jan 30, 2019

hmmm. When a root reference isn't given, flux_kvs_lookpuat() calls flux_kvs_lookup() for convenience.

This could be an issue if #1435 re-works how namespaces are passed to the KVS api.

@chu11 chu11 self-assigned this Jan 30, 2019
chu11 added a commit to chu11/flux-core that referenced this issue Jan 30, 2019
@chu11
libkvs/lookup: Remove namespace in lookupat
e8851de 
A lookupat is passed a root reference, therefore it should not
be concerned with a namespace.

Adjust code in modules/kvs to not require a namespace to be specified
when a lookup contains a root reference.

Update tests and documentation accordingly.

Fixes flux-framework#1970
chu11 added a commit to chu11/flux-core that referenced this issue Jan 31, 2019
@chu11
libkvs/lookup: Remove namespace in lookupat
3d208e9 
A lookupat is passed a root reference, therefore it should not
be concerned with a namespace.

Adjust code in modules/kvs to not require a namespace to be specified
when a lookup contains a root reference.

Update tests and documentation accordingly.

Fixes flux-framework#1970
@garlick garlick closed this as completed in d3de9fa Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chu11