Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvs: do not use namespace as a variable name #1963

Closed
chu11 opened this issue Jan 25, 2019 · 1 comment
Closed

kvs: do not use namespace as a variable name #1963

chu11 opened this issue Jan 25, 2019 · 1 comment
Assignees
@chu11

Comments

@chu11
Copy link
Member

chu11 commented Jan 25, 2019

As mentioned in #1949, it's a reserved word for C++.
@chu11
Copy link
Member Author

chu11 commented Jan 25, 2019 •
edited
Loading

FYI, some locations used name_space, if wanting to be consistent across all usage.

658e4f5

@chu11 chu11 mentioned this issue Jan 25, 2019
Merged
@chu11 chu11 self-assigned this Jan 26, 2019
chu11 added a commit to chu11/flux-core that referenced this issue Jan 28, 2019
@chu11
kvs: Rename 'namespace' variable globally
e7338fd 
The keyword 'namespace' is a reserved word in C++, so globally
remove use of the variable name 'namespace'.

Generally speaking, all local variables and function parameters
that were 'namespace' are now 'ns'.  In a few locations that
'namespace' was previously changed to 'name_space', use 'ns'
instead.

Structs that stored a namespace name now use the variable 'ns_name'.

In kvs-watch, rename 'struct namespace' to 'struct ns_monitor', and
use the variable 'nsm' for that struct.

Fixes flux-framework#1963
@chu11 chu11 mentioned this issue Jan 28, 2019
Merged
@garlick garlick mentioned this issue Jul 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@chu11