Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python: flux-security #1709

Closed
SteVwonder opened this issue Oct 6, 2018 · 4 comments
Closed

python: flux-security #1709

SteVwonder opened this issue Oct 6, 2018 · 4 comments

Comments

@SteVwonder
Copy link
Member

We need to wrap flux_security_* and flux_sign_wrap so that we can submit signed jobspec from python.

One way to do this is by adding a src/bindings/python directory to the flux-security repo and building the bindings in way similar to flux-core.

The other way we could do this, is from within flux-core. We could detect when core is configured with flux-security and then build the bindings against the installed flux-security.

I don't think the latter is any harder than the former, and the latter seems like the cleaner solution. It would avoid duplicating a bunch of build infrastructure between flux-core & flux-security, and it keeps flux-security small & simple (so it should be easier to audit).

Pinging @trws for his thoughts

@SteVwonder
Copy link
Member Author

One other thing to think about is what we want the behavior to be when flux-core is not configured with flux-security. Do we want import flux.security to fail with an ImportError? Or do we want the import to succeed and then have some other mechanism for alerting the caller that flux-security isn't available?

@trws
Copy link
Member

trws commented Oct 6, 2018 via email

@garlick
Copy link
Member

garlick commented Oct 9, 2018

Maybe we should look at having a flux_job_sign() function in flux-core that wraps flux-security's signing API when configured and does a "pass through" when not configured?

As I recall this is a bit tricky because the flux security API lets you override the config file location, signing method, etc, but perhaps its worth a look for that one interface, since it will need to be used externally.

@grondo
Copy link
Contributor

grondo commented Oct 9, 2018

Maybe we should look at having a flux_job_sign() function in flux-core that wraps flux-security's signing API when configured and does a "pass through" when not configured?

That would be useful. We had discussed that a user-built single-user instance of flux shouldn't have to be built with flux-security (though we should perhaps revisit that as well, we had also discussed possibly requiring flux-security at one point as well)

SteVwonder added a commit to SteVwonder/flux-core that referenced this issue Oct 11, 2018
    - include simple test of wrap/unwrap and security error messaging
    - test python3 with flux-security in at least one travis builder

Closes flux-framework#1709
SteVwonder added a commit to SteVwonder/flux-core that referenced this issue Oct 11, 2018
    - include simple test of wrap/unwrap and security error messaging
    - test python3 with flux-security in at least one travis builder

Closes flux-framework#1709
SteVwonder added a commit to SteVwonder/flux-core that referenced this issue Oct 11, 2018
    - include simple test of wrap/unwrap and security error messaging
    - test python3 with flux-security in at least one travis builder

Closes flux-framework#1709
SteVwonder added a commit to SteVwonder/flux-core that referenced this issue Oct 12, 2018
    - include simple test of wrap/unwrap and security error messaging
    - test python3 with flux-security in at least one travis builder

Closes flux-framework#1709
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants