Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlap between cmd/flux-kvs and t/kvs/basic #1127

Closed
garlick opened this issue Jul 25, 2017 · 0 comments
Closed

overlap between cmd/flux-kvs and t/kvs/basic #1127

garlick opened this issue Jul 25, 2017 · 0 comments
Assignees
@chu11

Comments

@garlick
Copy link
Member

garlick commented Jul 25, 2017

As noted in #1123, there is some overlap in functionality between the test command t/kvs/basic and the user command src/cmd/flux-kvs. We could probably cull subcommands in basic that have direct counterparts in flux-kvs and switch the test drivers over to use those.

Examples: get, link, readlink, mkdir, version, wait, dropcache, copy, and move are pretty much identical, or flux-kvs has some extra functionality.
@chu11 chu11 self-assigned this Aug 10, 2017
chu11 added a commit to chu11/flux-core that referenced this issue Aug 11, 2017
@chu11
t/kvs: Remove duplicate kvs test code
44a1340 
Remove get, put, version, wait, dropcache, copy, move, mkdir, link,
readlink in t/kvs/basic, as it is basically a duplicate of what is
in the flux-kvs command.

Update t1000-kvs-basic.t tests appropriately, using 'flux kvs' equivalent
as needed.

Fixes flux-framework#1127
@chu11 chu11 mentioned this issue Aug 11, 2017
Merged
@grondo grondo closed this as completed in 236d63a Aug 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chu11 chu11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garlick @chu11