flux-start: Eats cmdlines

[grondo]

It should be possible, and will be useful for the test suite, to preserve command line given to 'flux start' as much as possible. Currently, 'flux start' tries to concatenate args and thus drops quoting:

$ ./flux start -v --size=2 sh -c 'sleep 1'
flux-start: 0: ../broker/cmbd --size=2 --rank=0 --command=sh -c sleep 1
flux-start: 1: ../broker/cmbd --size=2 --rank=1
cmbd: 0-0: starting shell
sleep: missing operand
Try `sleep --help' for more information.
cmbd: 0: shutdown in 2s: shell (pid 7029) exited with rc=1
flux-start: 1 (pid 7022) exited with rc=1
flux-start: 0 (pid 7021) exited with rc=1

[grondo]

I didn't realize cmbd always invoked --command under the shell. Given that, for the above case at least, the following will work:

$ ./flux start -v --size=2 "sleep 1; ./flux up"
flux-start: 0: ../broker/cmbd --size=2 --rank=0 --command=sleep 1; ./flux up
flux-start: 1: ../broker/cmbd --size=2 --rank=1
cmbd: 0-0: starting shell
ok:     [0-1]
slow:   
fail:   
unknown:
cmbd: 0: shutdown in 2s: shell (pid 19271) exited with rc=0
flux-start: 1 (pid 19264) exited normally
flux-start: 0 (pid 19263) exited normally

[garlick]

I should probably let the command occupy the cmbd's leftover args rather than cram it into -c "command".

Right now the leftover args are module options. The whole module option passing thing is a mess. Maybe 'flux config' could make it easier to pass complex arguments between flux-start and cmbd, and leave cmbd positioned for being launched with a static config file at boot time.

[grondo]

I would keep this issue at low priority for now. Now that I understand "command" is run via sh -c
many things we'd like to do for testing will be possible, and for production use it is unlikely that
flux start will get common usage.

However, I do think the static config is a good option for cmdb.

Actually awhile ago I was thinking
it would be cool if we had an init type script for cmdb that could be passed on the command line
with methods for setting local config, waiting for events (kvs module loaded), and perhaps finally
launching a command. This sounds like a lot of work, but it might also be a way to address #8?

[trws]

This has been fixed has it not?

[grondo]

Yeah, I think we can close this one now ;-)

[trws]

Oddly, we have one much like this on broker now under some odd corner cases... if I can reproduce it I'll open another bug, but this one is ready to be gone. =)