common/libkvs: Add error check

Add input error check ot treeobj_create_symlink() with appropriate unit test. rebase: move earlier in commit series
flux-framework · Oct 31, 2017 · fcb92f4 · fcb92f4
1 parent 4c44423
commit fcb92f4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/common/libkvs/test/treeobj.c b/src/common/libkvs/test/treeobj.c
@@ -653,6 +653,9 @@ void test_symlink (void)
 {
     json_t *o, *data;
 
+    ok (treeobj_create_symlink (NULL) == NULL
+        && errno == EINVAL,
+        "treeobj_create_symlink fails on bad input with EINVAL");
     o = treeobj_create_symlink ("a.b.c");
     ok (o != NULL,
         "treeobj_create_symlink works");

diff --git a/src/common/libkvs/treeobj.c b/src/common/libkvs/treeobj.c
@@ -392,6 +392,11 @@ json_t *treeobj_create_symlink (const char *target)
 {
     json_t *obj;
 
+    if (!target) {
+        errno = EINVAL;
+        return NULL;
+    }
+
     if (!(obj = json_pack ("{s:i s:s s:s}", "ver", treeobj_version,
                                             "type", "symlink",
                                             "data", target))) {