Skip to content

Commit

Permalink
modules/kvs: Rename commit callback types
Browse files Browse the repository at this point in the history
Per style guidelines in RFC 7, rename function typedefs with '_f' at
the end of the name.  More specificlly, rename commit_ref_cb to commit_ref_f
and commit_cache_entry_cb to commit_cache_entry_f.
  • Loading branch information
chu11 committed Oct 12, 2017
1 parent 03f121b commit 0e4f97f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/modules/kvs/commit.c
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@ commit_process_t commit_process (commit_t *c,
return COMMIT_PROCESS_DIRTY_CACHE_ENTRIES;
}

int commit_iter_missing_refs (commit_t *c, commit_ref_cb cb, void *data)
int commit_iter_missing_refs (commit_t *c, commit_ref_f cb, void *data)
{
const char *ref;
int saved_errno, rc = 0;
Expand Down Expand Up @@ -712,7 +712,7 @@ int commit_iter_missing_refs (commit_t *c, commit_ref_cb cb, void *data)
}

int commit_iter_dirty_cache_entries (commit_t *c,
commit_cache_entry_cb cb,
commit_cache_entry_f cb,
void *data)
{
struct cache_entry *hp;
Expand Down
8 changes: 4 additions & 4 deletions src/modules/kvs/commit.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ typedef enum {
* commit_t API
*/

typedef int (*commit_ref_cb)(commit_t *c, const char *ref, void *data);
typedef int (*commit_ref_f)(commit_t *c, const char *ref, void *data);

typedef int (*commit_cache_entry_cb)(commit_t *c,
typedef int (*commit_cache_entry_f)(commit_t *c,
struct cache_entry *hp,
void *data);

Expand Down Expand Up @@ -75,15 +75,15 @@ commit_process_t commit_process (commit_t *c,
*
* return -1 in callback to break iteration
*/
int commit_iter_missing_refs (commit_t *c, commit_ref_cb cb, void *data);
int commit_iter_missing_refs (commit_t *c, commit_ref_f cb, void *data);

/* on commit stall, iterate through all dirty cache entries that need
* to be pushed to the content store.
*
* return -1 in callback to break iteration
*/
int commit_iter_dirty_cache_entries (commit_t *c,
commit_cache_entry_cb cb,
commit_cache_entry_f cb,
void *data);

/* convenience function for cleaning up a dirty cache entry that was
Expand Down

0 comments on commit 0e4f97f

Please sign in to comment.