Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: change shell plugin install directory #32

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

jameshcorbett
Copy link
Member

Problem: flux-coral2 is being added to mainline TOSS. The cray-pals plugin is built into the main shell pluginpath, so it is loaded by default. This introduces some performance overhead.

Solution: move the shell plugin install directory into a subdirectory of the shell pluginpath so it is not
loaded by default.

Problem: flux-coral2 is being added to mainline TOSS.
The cray-pals plugin is built into the main shell pluginpath, so
it is loaded by default. This introduces some performance overhead.

Solution: move the shell plugin install directory into a
subdirectory of the shell pluginpath so it is not
loaded by default.
Copy link
Contributor

@grondo grondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify mergify bot merged commit 5caa6f7 into flux-framework:master Oct 10, 2022
@jameshcorbett jameshcorbett deleted the shell-plugindir branch August 23, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants