Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dws2jgf: drop defaults for jgf simplification #209

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

jameshcorbett
Copy link
Member

Problem: JGF is too large, as described in #193.

As a first step to shrink it, do not output default values, instead skipping them and letting the JGF reader supply them.

Depends on changes introduced in flux-sched by flux-framework/flux-sched/pull/1293. This will remain as a draft until that is merged.

Problem: JGF is too large, as described in flux-framework#193.

As a first step to shrink it, do not output default values, instead
skipping them and letting the JGF reader supply them.

Depends on changes introduced in flux-sched by
flux-framework/flux-sched/pull/1293.
Problem: now that JGF generation is less verbose, the expected JGF
files need to be updated.

Update them.
@jameshcorbett jameshcorbett marked this pull request as ready for review October 1, 2024 00:18
@jameshcorbett jameshcorbett requested a review from cmoussa1 October 1, 2024 00:20
@jameshcorbett jameshcorbett mentioned this pull request Oct 1, 2024
Copy link
Member

@cmoussa1 cmoussa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@mergify mergify bot merged commit 8ca72d0 into flux-framework:master Oct 1, 2024
8 checks passed
@jameshcorbett jameshcorbett deleted the rabbit-jgf-reduction branch October 1, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants