Revert docker home mount and change hostname #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6cda6ad.
Problem: in order to get nnf-deploy's kind environment to match Flux's resource graph, the hostname of the docker container should be compute-01. Change the hostname in docker-run-checks.
jameshcorbett
force-pushed
the
docker-changes
branch
from
e96a5b9 to
b448d52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #154 was opened too hastily. By default,
kubectl(which is used all over the place in flux-coral2 tests) looks for a kubeconfig file in$HOME/.kube/config. And the flux-coral2 testsuite has logic in place, such as here, to manipulate kubernetes into working properly which was affected by PR #154. It caused test failures which were only visible when running with kubernetes (which CI doesn't do).The changes introduced by #154 are still desirable (see issue #156), but they will need to be introduced with more extensive changes which hopefully would make the kubernetes manipulations more straightforward.