t: change which user is deleted from association_table #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoussa1
changed the title
jameshcorbett
approved these changes
Nov 6, 2024
Problem: There is a test in t1023-flux-account-banks.t that makes sure the default bank of a user is updated when one of their user/bank rows is deleted from the database by removing it in the test prior, but the wrong user is deleted. Change which user is deleted in t1023-flux-account-banks.t. Make the "grep" check in the subsequent test more robust by checking that all three of the expected strings show up in the .out file instead of checking that the .out file contains any whole-word matches for just one of the patterns searched.
cmoussa1
force-pushed
the
fix.which.user.deleted
branch
from
872ddb4 to
87301bb
Compare
|
The test continued to pass because the Setting MWP here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is a test in
t1023-flux-account-banks.tthat makes sure the default bank of a user is updated when one of their user/bank rows is deleted from the database by removing it in the test prior, but the wrong user is deleted.This PR just changes which user is deleted in
t1023-flux-account-banks.t.