Skip to content
This repository has been archived by the owner on Dec 22, 2022. It is now read-only.

Commit

Permalink
Fix Adform's parameters regex (prebid#1214)
Browse files Browse the repository at this point in the history
* Added adform info file

* Added Adform adapter and bidder

* Updates from master

* Removed usersyncInfo from Adform adapter. Inverted Imp type check.

* Removed excessive loop

* Updated with the last master

* Create readme file for adform

* Fix Adform's parameters regex

Motivation: catastrophic backtracking during regex execution

Details:
- https://regex101.com/r/NNQrWq/1
- string to check "url_domain:keskustelu.suomi24.fi,url_path:/matkailu/matkakohteet/aasia,layout:lg,categories:Matkailu,main_category:Matkailu"

Co-authored-by: v.statkevich <[email protected]>
Co-authored-by: Olga Linkevich <[email protected]>
  • Loading branch information
3 people authored Mar 12, 2020
1 parent 890f5f6 commit fa55ad6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion static/bidder-params/adform.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"mkv": {
"type": "string",
"description": "Comma-separated key-value pairs. Forbidden symbols: &. Example: mkv='color:blue,length:350'",
"pattern": "^(\\s*|(([^,:&]*[^,:&\\s]+[^,:&]*)+:[^,:&]*,)*(([^,:&]*[^,:&\\s]+[^,:&]*)+:[^,:&]*,?))$"
"pattern": "^(\\s*|((\\s*[^,:&\\s]+\\s*:[^,:&]*)(,\\s*[^,:&\\s]+\\s*:[^,:&]*)*))$"
},
"mkw": {
"type": "string",
Expand Down

0 comments on commit fa55ad6

Please sign in to comment.