[Synacormedia] Add tagId bidder parameter (prebid#1165)

flux-dev-team · Jan 31, 2020 · 948f4d6 · 948f4d6
1 parent c1ec382
commit 948f4d6
Show file tree

Hide file tree

Showing 18 changed files with 253 additions and 45 deletions.
diff --git a/adapters/synacormedia/params_test.go b/adapters/synacormedia/params_test.go
@@ -40,9 +40,9 @@ func TestInvalidParams(t *testing.T) {
 }
 
 var validParams = []string{
-	`{"seatId": "123"}`,
+	`{"seatId": "123", "tagId":"234"}`,
 }
 
 var invalidParams = []string{
-	`{"seatId": 123}`,
+	`{"seatId": 123, "tagId":234}`,
 }
diff --git a/adapters/synacormedia/synacormedia.go b/adapters/synacormedia/synacormedia.go
@@ -20,6 +20,7 @@ type SynacorMediaAdapter struct {
 
 type SyncEndpointTemplateParams struct {
 	SeatId string
+	TagId  string
 }
 
 type ReqExt struct {
@@ -55,14 +56,23 @@ func (a *SynacorMediaAdapter) makeRequest(request *openrtb.BidRequest) (*adapter
 	var firstExtImp *openrtb_ext.ExtImpSynacormedia = nil
 
 	for _, imp := range request.Imp {
-		validImp, err := getExtImpObj(&imp)
+		validExtImpObj, err := getExtImpObj(&imp) // getExtImpObj returns {seatId:"", tagId:""}
 		if err != nil {
 			errs = append(errs, err)
 			continue
 		}
+		// if the bid request is missing seatId or TagId then ignore it
+		if validExtImpObj.SeatId == "" || validExtImpObj.TagId == "" {
+			errs = append(errs, &errortypes.BadServerResponse{
+				Message: fmt.Sprintf("Invalid Impression"),
+			})
+			continue
+		}
+		// right here is where we need to take out the tagId and then add it to imp
+		imp.TagID = validExtImpObj.TagId
 		validImps = append(validImps, imp)
 		if firstExtImp == nil {
-			firstExtImp = validImp
+			firstExtImp = validExtImpObj
 		}
 	}
 
@@ -72,11 +82,12 @@ func (a *SynacorMediaAdapter) makeRequest(request *openrtb.BidRequest) (*adapter
 
 	var err error
 
-	if firstExtImp == nil || firstExtImp.SeatId == "" {
+	if firstExtImp == nil || firstExtImp.SeatId == "" || firstExtImp.TagId == "" {
 		return nil, append(errs, &errortypes.BadServerResponse{
-			Message: fmt.Sprintf("Impression missing seat id"),
+			Message: fmt.Sprintf("Invalid Impression"),
 		})
 	}
+	// this is where the empty seatId is filled
 	re = &ReqExt{SeatId: firstExtImp.SeatId}
 
 	// create JSON Request Body

diff --git a/adapters/synacormedia/synacormediatest/exemplary/simple-banner.json b/adapters/synacormedia/synacormediatest/exemplary/simple-banner.json
@@ -14,7 +14,8 @@
         },
         "ext": {
           "bidder": {
-            "seatId": "1927"
+            "seatId": "prebid",
+            "tagId": "demo1"
           }
         }
       }
@@ -24,23 +25,25 @@
   "httpCalls": [
     {
       "expectedRequest": {
-        "uri": "http://1927.technoratimedia.com/openrtb/bids/1927",
+        "uri": "http://prebid.technoratimedia.com/openrtb/bids/prebid",
         "body": {
           "id": "test-request-id",
           "ext": {
-            "seatId": "1927"
+            "seatId": "prebid"
           },
           "imp": [
             {
               "id":"test-imp-id",
+              "tagid": "demo1",
               "banner": {
                 "format": [
                   {"w":300,"h":250}
                 ]
               },
               "ext": {
                 "bidder": {
-                  "seatId": "1927"
+                  "seatId": "prebid",
+                  "tagId": "demo1"
                 }
               }
             }

diff --git a/adapters/synacormedia/synacormediatest/exemplary/simple-video.json b/adapters/synacormedia/synacormediatest/exemplary/simple-video.json
@@ -10,7 +10,6 @@
     "imp": [
       {
         "id": "i3",
-        "tagid": "3020",
         "video": {
           "w": 300,
           "h": 250,
@@ -21,8 +20,9 @@
         },
         "metric": [],
         "ext": {
-          "bidder":{
-            "seatId":"1927"
+          "bidder": {
+            "seatId":"prebid",
+            "tagId": "demo1"
           }
         }
       }
@@ -31,7 +31,7 @@
   "httpCalls": [
     {
       "expectedRequest": {
-        "uri": "http://1927.technoratimedia.com/openrtb/bids/1927",
+        "uri": "http://prebid.technoratimedia.com/openrtb/bids/prebid",
         "body": {
           "id": "1",
           "site": {
@@ -40,12 +40,12 @@
             "publisher": {}
           },
           "ext": {
-            "seatId": "1927"
+            "seatId": "prebid"
           },
           "imp": [
             {
               "id": "i3",
-              "tagid": "3020",
+              "tagid": "demo1",
               "video": {
                 "w": 300,
                 "h": 250,
@@ -56,7 +56,8 @@
               },
               "ext": {
                 "bidder":{
-                  "seatId":"1927"
+                  "seatId":"prebid",
+                  "tagId": "demo1"
                 }
               }
             }

diff --git a/adapters/synacormedia/synacormediatest/params/banner.json b/adapters/synacormedia/synacormediatest/params/banner.json
@@ -1,3 +1,4 @@
 {
-  "seatId": "123"
+  "seatId": "123",
+  "tagId": "234"
 }
diff --git a/adapters/synacormedia/synacormediatest/params/video.json b/adapters/synacormedia/synacormediatest/params/video.json
@@ -1,3 +1,4 @@
 {
-  "seatId": "123"
+  "seatId": "123",
+  "tagId": "234"
 }
diff --git a/adapters/synacormedia/synacormediatest/supplemental/audio_response.json b/adapters/synacormedia/synacormediatest/supplemental/audio_response.json
@@ -9,7 +9,8 @@
         },
         "ext": {
           "bidder": {
-            "seatId": "1927"
+            "seatId": "prebid",
+            "tagId": "demo1"
           }
         }
       }
@@ -19,21 +20,23 @@
   "httpCalls": [
     {
       "expectedRequest": {
-        "uri": "http://1927.technoratimedia.com/openrtb/bids/1927",
+        "uri": "http://prebid.technoratimedia.com/openrtb/bids/prebid",
         "body": {
           "id": "test-request-id",
           "ext": {
-            "seatId": "1927"
+            "seatId": "prebid"
           },
           "imp": [
             {
               "id":"test-imp-id",
+              "tagid": "demo1",
               "audio": {
                 "mimes": ["video/mp4"]
               },
               "ext": {
                 "bidder": {
-                  "seatId": "1927"
+                  "seatId": "prebid",
+                  "tagId": "demo1"
                 }
               }
             }

diff --git a/adapters/synacormedia/synacormediatest/supplemental/bad_response.json b/adapters/synacormedia/synacormediatest/supplemental/bad_response.json
@@ -18,7 +18,8 @@
         },
         "ext": {
           "bidder": {
-            "seatId": "1927"
+            "seatId": "prebid",
+            "tagId": "demo1"
           }
         }
       }
@@ -28,15 +29,16 @@
   "httpCalls": [
     {
       "expectedRequest": {
-        "uri": "http://1927.technoratimedia.com/openrtb/bids/1927",
+        "uri": "http://prebid.technoratimedia.com/openrtb/bids/prebid",
         "body": {
           "id": "test-request-id",
           "ext": {
-            "seatId": "1927"
+            "seatId": "prebid"
           },
           "imp": [
             {
               "id":"test-imp-id",
+              "tagid": "demo1",
               "banner": {
                 "format": [
                   {"w":300,"h":250},
@@ -45,7 +47,8 @@
               },
               "ext": {
                 "bidder": {
-                  "seatId": "1927"
+                  "seatId": "prebid",
+                  "tagId": "demo1"
                 }
               }
             }

diff --git a/adapters/synacormedia/synacormediatest/supplemental/bad_seat_id.json b/adapters/synacormedia/synacormediatest/supplemental/bad_seat_id.json
@@ -14,7 +14,8 @@
         },
         "ext": {
           "bidder": {
-            "seatId": 1927
+            "seatId": 1927,
+            "tagId": "demo1"
           }
         }
       }

diff --git a/adapters/synacormedia/synacormediatest/supplemental/missing_seat_id.json b/adapters/synacormedia/synacormediatest/supplemental/missing_seat_id.json
@@ -14,6 +14,7 @@
         },
         "ext": {
           "bidder": {
+            "tagId": "demo1"
           }
         }
       }
@@ -22,7 +23,7 @@
 
   "expectedMakeRequestsErrors": [
     {
-      "value": "Impression missing seat id",
+      "value": "Invalid Impression",
       "comparison": "literal"
     }
   ]

diff --git a/adapters/synacormedia/synacormediatest/supplemental/missing_tag_id.json b/adapters/synacormedia/synacormediatest/supplemental/missing_tag_id.json
@@ -0,0 +1,30 @@
+{
+  "mockBidRequest": {
+    "id": "test-request-id",
+    "imp": [
+      {
+        "id": "test-imp-id",
+        "banner": {
+          "format": [
+            {
+              "w": 300,
+              "h": 250
+            }
+          ]
+        },
+        "ext": {
+          "bidder": {
+            "seatId": "prebid"
+          }
+        }
+      }
+    ]
+  },
+
+  "expectedMakeRequestsErrors": [
+    {
+      "value": "Invalid Impression",
+      "comparison": "literal"
+    }
+  ]
+}
diff --git a/adapters/synacormedia/synacormediatest/supplemental/native_response.json b/adapters/synacormedia/synacormediatest/supplemental/native_response.json
@@ -9,7 +9,8 @@
         },
         "ext": {
           "bidder": {
-            "seatId": "1927"
+            "seatId": "prebid",
+            "tagId": "demo1"
           }
         }
       }
@@ -19,21 +20,23 @@
   "httpCalls": [
     {
       "expectedRequest": {
-        "uri": "http://1927.technoratimedia.com/openrtb/bids/1927",
+        "uri": "http://prebid.technoratimedia.com/openrtb/bids/prebid",
         "body": {
           "id": "test-request-id",
           "ext": {
-            "seatId": "1927"
+            "seatId": "prebid"
           },
           "imp": [
             {
               "id":"test-imp-id",
+              "tagid": "demo1",
               "native": {
                 "request": ""
               },
               "ext": {
                 "bidder": {
-                  "seatId": "1927"
+                  "seatId": "prebid",
+                  "tagId": "demo1"
                 }
               }
             }