-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(connectivity_plus): Add Swift Package Manager support #3173
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
cf65d62
add spm support for connectivity
charafau 566b392
rename file to package.swift
charafau f7a055d
remove objc files, add spm support
charafau 631faca
reverted deleted file
charafau 92a88fb
fix plugin swift code, change example pub spec to use library from repo
charafau 1479d11
reverted changes in pubspec
charafau a5f16a2
Merge branch 'main' into connectivity-spm
vbuberen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
8 changes: 0 additions & 8 deletions
8
packages/connectivity_plus/connectivity_plus/darwin/Classes/ConnectivityPlusPlugin.h
This file was deleted.
Oops, something went wrong.
15 changes: 0 additions & 15 deletions
15
packages/connectivity_plus/connectivity_plus/darwin/Classes/ConnectivityPlusPlugin.m
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,17 +14,12 @@ Downloaded by pub (not CocoaPods). | |
s.author = { 'Flutter Community Team' => '[email protected]' } | ||
s.source = { :http => 'https://github.com/fluttercommunity/plus_plugins/tree/main/packages/connectivity_plus' } | ||
s.documentation_url = 'https://pub.dev/packages/connectivity_plus' | ||
s.source_files = [ | ||
'Classes/**/*' | ||
] | ||
s.public_header_files = [ | ||
'Classes/**/*.h' | ||
] | ||
s.source_files = 'connectivity_plus/Sources/connectivity_plus/**/*.swift' | ||
s.ios.dependency 'Flutter' | ||
s.osx.dependency 'FlutterMacOS' | ||
s.ios.deployment_target = '12.0' | ||
s.osx.deployment_target = '10.14' | ||
s.swift_version = '5.0' | ||
s.pod_target_xcconfig = { 'DEFINES_MODULE' => 'YES' } | ||
s.ios.resource_bundles = {'connectivity_plus_privacy' => ['PrivacyInfo.xcprivacy']} | ||
s.ios.resource_bundles = {'connectivity_plus_privacy' => ['connectivity_plus/Sources/connectivity_plus/PrivacyInfo.xcprivacy']} | ||
end |
25 changes: 25 additions & 0 deletions
25
packages/connectivity_plus/connectivity_plus/darwin/connectivity_plus/Package.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
// swift-tools-version: 5.9 | ||
// The swift-tools-version declares the minimum version of Swift required to build this package. | ||
|
||
import PackageDescription | ||
|
||
let package = Package( | ||
name: "connectivity_plus", | ||
platforms: [ | ||
.iOS("12.0"), | ||
.macOS("10.14") | ||
], | ||
products: [ | ||
.library(name: "connectivity-plus", targets: ["connectivity_plus"]) | ||
], | ||
dependencies: [], | ||
targets: [ | ||
.target( | ||
name: "connectivity_plus", | ||
dependencies: [], | ||
resources: [ | ||
.process("PrivacyInfo.xcprivacy"), | ||
] | ||
) | ||
] | ||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would removing this code cause an issue on older apps still using Obj-C?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure on 99% it won't. Example project works without changing anything, support for swift in plugin was here already.