-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(device_info_plus): Add Swift Package Manager support #3167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not super familiar with the process yet, but took a look at it, and left some comments.
Also, we should do the same for the macOS part of the project, right? In that case, we should indicate in the Title that this only covers iOS
packages/device_info_plus/device_info_plus/ios/device_info_plus/.build/workspace-state.json
Outdated
Show resolved
Hide resolved
...ce_info_plus/ios/device_info_plus/Sources/device_info_plus/include/device_info_plus/.gitkeep
Outdated
Show resolved
Hide resolved
Thanks for fast review, this is also my first time doing it. I will apply suggestions from you and @koji-1009 and upload today. Hopefully migrate all plugins |
Thanks guys, should be good now. I also added support for macos |
Please take a look at the macos CI jobs, as they are now failing. |
Sorry didn't notice that it's a scrollable list 😅 fixed and is passing now |
packages/device_info_plus/device_info_plus/ios/device_info_plus.podspec
Outdated
Show resolved
Hide resolved
packages/device_info_plus/device_info_plus/ios/device_info_plus/Package.swift
Outdated
Show resolved
Hide resolved
Adjust whitespaces Co-authored-by: Loïc Sharma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on iOS and MacOS devices with both SPM on/off and everything works alright.
Thanks for your contribution. Merging.
ref: #3152
Since SPM support is comming I plan to add it to all plugins.
Followed the guide - https://docs.flutter.dev/packages-and-plugins/swift-package-manager/for-plugin-authors
and checked it for both cocoapods and spm