Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4 - use draggable scrollbar with sliver list #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #4 - use draggable scrollbar with sliver list #12

wants to merge 1 commit into from

Conversation

Miolin
Copy link

@Miolin Miolin commented Dec 30, 2018

change BoxScrollView to Widget

@jeprojects
Copy link

Can this be pushed to a new pub release?

@DenchikBY
Copy link

Have you tested this?
Doesn't work for me inside CustomScrollView with sliver children. I'm trying to use it as a parent of SliverList.

A RenderViewport expected a child of type RenderSliver but received a child of type _RenderLayoutBuilder.

It works for me.
Just regard a CustomScrollView with sliver children as a ListView in the example.

not working for me as well. i have customSCrollView and sliverList with sliverAppBar. could you please share your widget tree

Just looks like tihs↓ (myStickyBar is a sliverAppBar
Snipaste_2020-02-25_11-44-33
PS:You may need to change BoxScrollView to Widget following the commit above firstly.

But in your case wraps whole CustomScrollView, app bar too and scrollbar will be above it. Is it possible to wrap only SliverList?

Copy link

@Maadhav Maadhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really need to merge this in the master, fixed my problem.

@vauvenal5
Copy link

This PR is open since 2018... Is there any obvious issue with it?

Copy link

@Rizwan-Raza Rizwan-Raza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some errors after these changes.
Something like

Cannot get size from a render object that has been marked dirty for layout.


The size of this render object is ambiguous because this render object has been modified since it was last laid out, 
which typically means that the size getter was called too early in the pipeline (e.g., during the build phase) before the framework has determined the size and position of the render objects during layout.

@emvaized
Copy link

@Rizwan-Raza I get this error only when I pass ListView with shrinkWrap: true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants