Use before/afterPaintImage callbacks in editing too #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are your requirements about it? Can you illustrate with a scenario? |
|
I use this to draw a checkerboard background behind the image to show transparency. It works just fine when the mode is none or gesture, but as soon as the mode is edit, the callbacks are ignored. Adding the 2 lines of code seems to add the functionality back without any side effects although I haven't tested thouroughly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason these seem to be disable whe the edit mode is enabled. I couldn't find any mention of this anywhere so I assume this is a bug/not intentional behaviour. Seems to work fine.