-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate CRLF
from the copied flutter
directory for Docker build
#9298
Conversation
Visit the preview URL for this PR (updated for commit 0a78c2e): https://flutter-docs-prod--pr9298-fix-crlf-to-lf-i9xidbu2.web.app (expires Sat, 02 Sep 2023 18:46:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d5ba327eec813901cac8396c4f458b02288624ab |
@AlexV525 : I like this change. Did it work on your machine? (I ask because I have no easy way to test.) |
I haven't had access to a Windows setup for a while, but I'll work on getting something set up this weekend. Thanks for staying on top of this Alex! Would you mind adding a comment to explain the line? I think it might be easy to forget why it's there in the future. |
Oh, I just place the command as an alias: |
Nah, it not actually working since my clone is already in |
Notice that this only resolves a single part of the whole setup process. |
Alternatively, we can always clone the flutter repo rather than copying. |
I'd perfer this after some experiments. Will submit a separate PR for it. And you guys can decide which to take. |
See #9307 |
Closing in favor of #9307. |
Force eliminate
CRLF
from the copiedflutter
directory.Issues fixed (partially) by this PR (if any):
Presubmit checklist