Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix invalid link flutter.dev #11295

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix invalid link flutter.dev #11295

merged 3 commits into from
Oct 22, 2024
+1 −1

Conversation

nickf2k
Copy link
Contributor

@nickf2k nickf2k commented Oct 21, 2024

fix invalid flutter.dev link because we no longer use it

fix issue #11294

Presubmit checklist

  • This PR is marked as draft with an explanation if not meant to land until a future stable release.
  • This PR doesn’t contain automatically generated corrections (Grammarly or similar).
  • This PR follows the Google Developer Documentation Style Guidelines — for example, it doesn’t use i.e. or e.g., and it avoids I and we (first person).
  • This PR uses semantic line breaks of 80 characters or fewer.

@nickf2k nickf2k requested review from sfshaza2, parlough and a team as code owners October 21, 2024 08:20
sfshaza2
sfshaza2 reviewed Oct 21, 2024
View reviewed changes
Copy link
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @nickf2k! Can you tell me why you find this change to be needed? As it's written now, the link takes me to the correct page.

@parlough
Copy link
Member

Can you tell me why you find this change to be needed? As it's written now, the link takes me to the correct page.

It's only working due to a temporary redirect we added to avoid breaking links from the flutter tool.

Now the flutter tool will output https://flutter.dev/to/macos-android-setup in this case.

@parlough
Copy link
Member

/gcbrun

@flutter-website-bot
Copy link
Collaborator

Visit the preview URL for this PR (updated for commit bd45f25):

https://flutter-docs-prod--pr11295-main-yn4z3h8h.web.app

parlough
parlough approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@parlough parlough left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching and fixing this! It's appreciated :D

@parlough parlough merged commit 6d029b3 into flutter:main Oct 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfshaza2 sfshaza2 sfshaza2 left review comments

@parlough parlough parlough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickf2k @parlough @flutter-website-bot @sfshaza2