Added ChromeOS, Linux GS #10302
Merged
Added ChromeOS, Linux GS #10302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atsansone
requested review from
sfshaza2,
parlough,
khanhnwin,
domesticmouse and
MaryaBelanger
as code owners
|
Visit the preview URL for this PR (updated for commit a31a869): https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app |
domesticmouse
approved these changes
Mar 19, 2024
|
LGTM. Thanks! |
|
OK, this really should have had a writer review, but I don't have time right now. |
atsansone
added a commit
that referenced
this pull request
Mar 19, 2024
This reverts commit 1d17244.
sfshaza2
pushed a commit
that referenced
this pull request
Mar 19, 2024
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Mar 19, 2024
Reverts flutter#10302 Needs more time for copy review. PTAL @sfshaza2 !
atsansone
added a commit
that referenced
this pull request
Mar 20, 2024
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started. Fixes #10255 Fixes #10186 Fixes #10188 Fixes #10191 Reviewed and approved by @anderdobo in #10302 ---- ## New pages These are mostly reusing includes or include templates from the other Getting Started pages. The main new pages are under: - src/_includes/docs/install/reqs/linux/base.md - src/get-started/install/chromeos/ - src/get-started/install/linux/ - src/platform-integration/android/install-android/ - src/platform-integration/linux/install-linux/ - src/platform-integration/web/install-web/ Changed to fix auto-population of current build artifacts in terminal code blocks. - src/assets/js/archive.js Added tabs - src/assets/js/main.js Refactored other framework pages to clean up includes. ---- ## New page links It will help to see these staged because of the heavy reuse and Liquid logic. ### ChromeOS install - [Install on ChromeOS landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/) - [Install Flutter with Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/android/) - [Install Flutter with web tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/web/) ### Linux Install - [Install on Linux landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/) - [Install Flutter for Linux Desktop on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/desktop) - [Install Flutter with Android tools on on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/android) - [Install Flutter with web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/web) ### Add Linux desktop to Linux Android or Web install - [Add Linux Desktop tools landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/) - [Add Linux Desktop tools to Flutter & Android tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-android) - [Add Linux Desktop tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-web) ### Add Android to Linux Desktop install - [Add Android tools to Flutter & Linux Desktop tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-linux) - [Add Android tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-linux) ### Add Android to ChromeOS Web install - [Add Android tools to Flutter on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-chromeos) ### Add Web to Linux Desktop install - [Add web tools to Flutter & Linux Desktop tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-linux-desktop) - [Add web tools to Flutter & Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-linux) ### Add Web to ChromeOS Android install - [Add web tools to ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-chromeos) --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: John Ryan <[email protected]>
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started. Fixes flutter#10255 Fixes flutter#10186 Fixes flutter#10188 Fixes flutter#10191 ---- ## Adds the following pages: ### ChromeOS install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/chromeos/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/chromeos/android/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/chromeos/web/ ### Linux Install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/desktop - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/android - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/web ### Add Linux desktop to Linux Android or Web install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/linux/install-linux/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/linux/install-linux/install-linux-from-android - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/linux/install-linux/install-linux-from-web ### Add Android to Linux Desktop install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/android/install-android/install-android-from-linux - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/android/install-android/install-android-from-web-on-linux ### Add Android to ChromeOS Web install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/android/install-android/install-android-from-web-on-chromeos ### Add Web to Linux Desktop install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/web/install-web/install-web-from-linux-desktop - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/web/install-web/install-web-from-android-on-linux ### Add Web to ChromeOS Android install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/web/install-web/install-web-from-android-on-chromeos ---- ## Refactors - Flutter file replacement into command lines on all install pages - Flutter doctor results for all combinations --------- Co-authored-by: Brett Morgan <[email protected]>
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
Reverts flutter#10302 Needs more time for copy review. PTAL @sfshaza2 !
atsansone
added a commit
to atsansone/website
that referenced
this pull request
Apr 5, 2024
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started. Fixes flutter#10255 Fixes flutter#10186 Fixes flutter#10188 Fixes flutter#10191 Reviewed and approved by @anderdobo in flutter#10302 ---- ## New pages These are mostly reusing includes or include templates from the other Getting Started pages. The main new pages are under: - src/_includes/docs/install/reqs/linux/base.md - src/get-started/install/chromeos/ - src/get-started/install/linux/ - src/platform-integration/android/install-android/ - src/platform-integration/linux/install-linux/ - src/platform-integration/web/install-web/ Changed to fix auto-population of current build artifacts in terminal code blocks. - src/assets/js/archive.js Added tabs - src/assets/js/main.js Refactored other framework pages to clean up includes. ---- ## New page links It will help to see these staged because of the heavy reuse and Liquid logic. ### ChromeOS install - [Install on ChromeOS landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/) - [Install Flutter with Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/android/) - [Install Flutter with web tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/web/) ### Linux Install - [Install on Linux landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/) - [Install Flutter for Linux Desktop on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/desktop) - [Install Flutter with Android tools on on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/android) - [Install Flutter with web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/web) ### Add Linux desktop to Linux Android or Web install - [Add Linux Desktop tools landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/) - [Add Linux Desktop tools to Flutter & Android tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-android) - [Add Linux Desktop tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-web) ### Add Android to Linux Desktop install - [Add Android tools to Flutter & Linux Desktop tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-linux) - [Add Android tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-linux) ### Add Android to ChromeOS Web install - [Add Android tools to Flutter on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-chromeos) ### Add Web to Linux Desktop install - [Add web tools to Flutter & Linux Desktop tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-linux-desktop) - [Add web tools to Flutter & Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-linux) ### Add Web to ChromeOS Android install - [Add web tools to ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-chromeos) --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: John Ryan <[email protected]>
sfshaza2
reviewed
Apr 6, 2024
| @@ -0,0 +1,38 @@ | |||
| --- | |||
| title: Add Android devtools for Flutter from Web on Linux start | |||
There was a problem hiding this comment.
I am exceedingly confused by what this means. First of all, "devtools" is not a word. Flutter and Dart and Flutter (or Dart) DevTools. Chrome has Chrome DevTools. There, so far as I know, aren't any "web DevTools". I don't even understand this title.
| @@ -0,0 +1,37 @@ | |||
| --- | |||
| title: Add Linux devtools for Flutter | |||
There was a problem hiding this comment.
What is Linux devtools? That is not a thing. There are Chrome DevTools and Dart/Flutter DevTools. I don't even understand what this means.
| @@ -0,0 +1,19 @@ | |||
| --- | |||
| title: Add Linux devtools to Flutter from Android start | |||
| @@ -0,0 +1,18 @@ | |||
| --- | |||
| title: Add Linux devtools to Flutter from web start | |||
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| title: Add Web devtools to Flutter from Android on ChromeOS start | |||
There was a problem hiding this comment.
Ditto. No such thing as "Web devtools".
| @@ -0,0 +1,17 @@ | |||
| --- | |||
| title: Add Web devtools to Flutter from Android on Linux start | |||
| @@ -0,0 +1,16 @@ | |||
| --- | |||
| title: Add Web devtools to Flutter from Linux start | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started.
Fixes #10255
Fixes #10186
Fixes #10188
Fixes #10191
Adds the following pages:
ChromeOS install
Linux Install
Add Linux desktop to Linux Android or Web install
Add Android to Linux Desktop install
Add Android to ChromeOS Web install
Add Web to Linux Desktop install
Add Web to ChromeOS Android install
Refactors