-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ChromeOS, Linux GS #10302
Added ChromeOS, Linux GS #10302
Conversation
Visit the preview URL for this PR (updated for commit a31a869): https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app |
LGTM. Thanks! |
OK, this really should have had a writer review, but I don't have time right now. |
This reverts commit 1d17244.
Reverts flutter#10302 Needs more time for copy review. PTAL @sfshaza2 !
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started. Fixes #10255 Fixes #10186 Fixes #10188 Fixes #10191 Reviewed and approved by @anderdobo in #10302 ---- ## New pages These are mostly reusing includes or include templates from the other Getting Started pages. The main new pages are under: - src/_includes/docs/install/reqs/linux/base.md - src/get-started/install/chromeos/ - src/get-started/install/linux/ - src/platform-integration/android/install-android/ - src/platform-integration/linux/install-linux/ - src/platform-integration/web/install-web/ Changed to fix auto-population of current build artifacts in terminal code blocks. - src/assets/js/archive.js Added tabs - src/assets/js/main.js Refactored other framework pages to clean up includes. ---- ## New page links It will help to see these staged because of the heavy reuse and Liquid logic. ### ChromeOS install - [Install on ChromeOS landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/) - [Install Flutter with Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/android/) - [Install Flutter with web tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/web/) ### Linux Install - [Install on Linux landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/) - [Install Flutter for Linux Desktop on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/desktop) - [Install Flutter with Android tools on on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/android) - [Install Flutter with web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/web) ### Add Linux desktop to Linux Android or Web install - [Add Linux Desktop tools landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/) - [Add Linux Desktop tools to Flutter & Android tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-android) - [Add Linux Desktop tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-web) ### Add Android to Linux Desktop install - [Add Android tools to Flutter & Linux Desktop tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-linux) - [Add Android tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-linux) ### Add Android to ChromeOS Web install - [Add Android tools to Flutter on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-chromeos) ### Add Web to Linux Desktop install - [Add web tools to Flutter & Linux Desktop tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-linux-desktop) - [Add web tools to Flutter & Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-linux) ### Add Web to ChromeOS Android install - [Add web tools to ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-chromeos) --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: John Ryan <[email protected]>
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started. Fixes flutter#10255 Fixes flutter#10186 Fixes flutter#10188 Fixes flutter#10191 ---- ## Adds the following pages: ### ChromeOS install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/chromeos/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/chromeos/android/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/chromeos/web/ ### Linux Install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/desktop - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/android - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/get-started/install/linux/web ### Add Linux desktop to Linux Android or Web install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/linux/install-linux/ - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/linux/install-linux/install-linux-from-android - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/linux/install-linux/install-linux-from-web ### Add Android to Linux Desktop install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/android/install-android/install-android-from-linux - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/android/install-android/install-android-from-web-on-linux ### Add Android to ChromeOS Web install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/android/install-android/install-android-from-web-on-chromeos ### Add Web to Linux Desktop install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/web/install-web/install-web-from-linux-desktop - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/web/install-web/install-web-from-android-on-linux ### Add Web to ChromeOS Android install - https://flutter-docs-prod--pr10302-fix-10255-q3e2r9ic.web.app/platform-integration/web/install-web/install-web-from-android-on-chromeos ---- ## Refactors - Flutter file replacement into command lines on all install pages - Flutter doctor results for all combinations --------- Co-authored-by: Brett Morgan <[email protected]>
Reverts flutter#10302 Needs more time for copy review. PTAL @sfshaza2 !
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started. Fixes flutter#10255 Fixes flutter#10186 Fixes flutter#10188 Fixes flutter#10191 Reviewed and approved by @anderdobo in flutter#10302 ---- ## New pages These are mostly reusing includes or include templates from the other Getting Started pages. The main new pages are under: - src/_includes/docs/install/reqs/linux/base.md - src/get-started/install/chromeos/ - src/get-started/install/linux/ - src/platform-integration/android/install-android/ - src/platform-integration/linux/install-linux/ - src/platform-integration/web/install-web/ Changed to fix auto-population of current build artifacts in terminal code blocks. - src/assets/js/archive.js Added tabs - src/assets/js/main.js Refactored other framework pages to clean up includes. ---- ## New page links It will help to see these staged because of the heavy reuse and Liquid logic. ### ChromeOS install - [Install on ChromeOS landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/) - [Install Flutter with Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/android/) - [Install Flutter with web tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/chromeos/web/) ### Linux Install - [Install on Linux landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/) - [Install Flutter for Linux Desktop on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/desktop) - [Install Flutter with Android tools on on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/android) - [Install Flutter with web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/get-started/install/linux/web) ### Add Linux desktop to Linux Android or Web install - [Add Linux Desktop tools landing page](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/) - [Add Linux Desktop tools to Flutter & Android tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-android) - [Add Linux Desktop tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/linux/install-linux/install-linux-from-web) ### Add Android to Linux Desktop install - [Add Android tools to Flutter & Linux Desktop tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-linux) - [Add Android tools to Flutter & Web tools on Linux](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-linux) ### Add Android to ChromeOS Web install - [Add Android tools to Flutter on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/android/install-android/install-android-from-web-on-chromeos) ### Add Web to Linux Desktop install - [Add web tools to Flutter & Linux Desktop tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-linux-desktop) - [Add web tools to Flutter & Android tools on ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-linux) ### Add Web to ChromeOS Android install - [Add web tools to ChromeOS](https://flutter-docs-prod--pr10316-fix-10255-ayluprrv.web.app/platform-integration/web/install-web/install-web-from-android-on-chromeos) --------- Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]> Co-authored-by: John Ryan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the confusion about "devtools", which really does confuse me, this seems ok. It's very hard to evaluate changes that are mostly infrastructure and include files.
But the "xxx devtools" language should be cleaned up.
@@ -0,0 +1,38 @@ | |||
--- | |||
title: Add Android devtools for Flutter from Web on Linux start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am exceedingly confused by what this means. First of all, "devtools" is not a word. Flutter and Dart and Flutter (or Dart) DevTools. Chrome has Chrome DevTools. There, so far as I know, aren't any "web DevTools". I don't even understand this title.
@@ -0,0 +1,37 @@ | |||
--- | |||
title: Add Linux devtools for Flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is Linux devtools? That is not a thing. There are Chrome DevTools and Dart/Flutter DevTools. I don't even understand what this means.
@@ -0,0 +1,19 @@ | |||
--- | |||
title: Add Linux devtools to Flutter from Android start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto to above confusion.
@@ -0,0 +1,18 @@ | |||
--- | |||
title: Add Linux devtools to Flutter from web start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
@@ -0,0 +1,17 @@ | |||
--- | |||
title: Add Web devtools to Flutter from Android on ChromeOS start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto. No such thing as "Web devtools".
@@ -0,0 +1,17 @@ | |||
--- | |||
title: Add Web devtools to Flutter from Android on Linux start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto.
@@ -0,0 +1,16 @@ | |||
--- | |||
title: Add Web devtools to Flutter from Linux start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ditto
Adds ChromeOS, Linux GS pages plus all 2nd level add-ons to getting started.
Fixes #10255
Fixes #10186
Fixes #10188
Fixes #10191
Adds the following pages:
ChromeOS install
Linux Install
Add Linux desktop to Linux Android or Web install
Add Android to Linux Desktop install
Add Android to ChromeOS Web install
Add Web to Linux Desktop install
Add Web to ChromeOS Android install
Refactors