Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dash] Fix broken external links #1413

Closed
chalin opened this issue Oct 9, 2018 · 4 comments
Closed

[dash] Fix broken external links #1413

chalin opened this issue Oct 9, 2018 · 4 comments
Assignees
Labels
p1-high Major but not urgent concern: Resolve in months. Update each month.
Milestone

Comments

@chalin
Copy link
Contributor

chalin commented Oct 9, 2018

In particular note the 400 status codes.

Related: #1412

http://localhost:4002/development/ui/widgets/widgetindex
- (35:2) <link> => https://flutter-io-staging-1.firebaseapp.com/development/ui/widgets/widget (HTTP 404)

http://localhost:4002/get-started/flutter-for/android-devs
- (1355:0) 'StackOve..' => https://stackoverflow.com/questions/46241071/create-signature-area-%0Afor-mobile-app-in-dart-flutter (HTTP 400)

http://localhost:4002/get-started/flutter-for/ios-devs
- (1337:0) 'StackOve..' => https://stackoverflow.com/questions/46241071/create-signature-area-%0Afor-mobile-app-in-dart-flutter (HTTP 400)
- (2160:0) 'AppLifec..' => https://docs.flutter.io/flutter/dart-ui%0A/AppLifecycleState-class.html (connection failed)

http://localhost:4002/get-started/flutter-for/react-native-devs
- (2120:0) 'TextStyle' => https://docs.flutter.io/flutter/dart-ui/TextStyle-class.html (connection failed)
- (2282:0) 'BuildCon..' => https://docs.flutter.io/flutter/widgets/BuildContext-class.html (connection failed)
- (2775:0) 'context' => https://docs.flutter.io/flutter/widgets/BuildContext-class.html (connection failed)

http://localhost:4002/get-started/flutter-for/web-devs
- (1015:0) 'BoxConst..' => https://docs.flutter.io/flutter/rendering/BoxConstraints-class.html (connection failed)
- (1391:0) 'BorderRa..' => https://docs.flutter.io/flutter/painting/BorderRadius-class.html (connection failed)
- (1453:0) 'BoxShadow' => https://docs.flutter.io/flutter/painting/BoxShadow-class.html (connection failed)

http://localhost:4002/get-started/flutter-for/xamarin-forms-devs
- (1519:0) 'StackOve..' => https://stackoverflow.com/questions/46241071/create-signature-area-%0Afor-mobile-app-in-dart-flutter (HTTP 400)

http://localhost:4002/get-started/install/windows
- (862:0) 'PowerShe..' => https://docs.microsoft.com/en-us/powershell/scripting/_installing-windows-powershell#upgrading-existing-windows-powershell (HTTP 404)
- (862:0) 'PowerShe..' => https://docs.microsoft.com/en-us/powershell/scripting/_installing-windows-powershell#upgrading-existing-windows-powershell (HTTP 404)

@filiph, also notice the connection failures, these may be related to dart-lang/site-www#1107.

cc @Sfshaza

@chalin chalin mentioned this issue Oct 9, 2018
52 tasks
@chalin chalin added this to the 18Q4-sprint milestone Oct 17, 2018
@Sfshaza Sfshaza added the p1-high Major but not urgent concern: Resolve in months. Update each month. label Oct 19, 2018
@Sfshaza
Copy link
Contributor

Sfshaza commented Oct 19, 2018

Is this still true? I haven't seen it.

@chalin
Copy link
Contributor Author

chalin commented Oct 19, 2018

It probably still is true. We don't have external link checking enabled for dash yet.

@sfshaza2
Copy link
Contributor

Changing to P0.

@sfshaza2 sfshaza2 added the p0-critical Critical and urgent concern: breaks builds, impacts team velocity. Resolve in weeks. Update weekly. label Oct 29, 2018
@chalin chalin removed the p1-high Major but not urgent concern: Resolve in months. Update each month. label Oct 30, 2018
@chalin chalin self-assigned this Nov 2, 2018
@sfshaza2 sfshaza2 added p1-high Major but not urgent concern: Resolve in months. Update each month. and removed p0-critical Critical and urgent concern: breaks builds, impacts team velocity. Resolve in weeks. Update weekly. labels Nov 2, 2018
@chalin chalin self-assigned this Nov 2, 2018
@chalin chalin modified the milestones: 18Q4-sprint-1, 18Q4 Nov 13, 2018
chalin added a commit that referenced this issue Nov 15, 2018
Contributes to #1413, by fixing all 404 errors. All we are left with now are connection failures (filiph/linkcheck#29).
chalin added a commit that referenced this issue Nov 16, 2018
Contributes to #1413, by fixing all 404 errors. All we are left with now are connection failures (filiph/linkcheck#29).
@chalin
Copy link
Contributor Author

chalin commented Nov 16, 2018

All fixed!

@chalin chalin closed this as completed Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-high Major but not urgent concern: Resolve in months. Update each month.
Projects
None yet
Development

No branches or pull requests

3 participants