Re-enabled super_editor tests #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gspencergoog looks like we've got some failing tests |
|
Yep, it looks like there's a bug in While we wait for a fix, would it be OK if I removed some unused parameters from your |
|
@gspencergoog I'll need to see what you'd like to remove. Content layers is an extremely fragile hack that's critical to super_editor, but if there are truly some unused and irrelevant code then I can look into deleting it. |
|
OK, I sent you the PR: superlistapp/super_editor#1630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-enables the
super_editortests now that it has been migrated to useKeyEventinstead ofRawKeyEvent.Related Issues
RawKeyEventandRawKeyboard, et al should be deprecated and removed flutter#136419