platform specific instructions added #182
Conversation
Peddinti-Sriram-Bharadwaj
requested a review
from erickzanardo
as a code owner
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
|
||
| bool get isAndroid => !kIsWeb && Platform.isAndroid; | ||
| bool get isIOS => !kIsWeb && Platform.isIOS; | ||
| bool get isWindows => !kIsWeb && Platform.isWindows; |
There was a problem hiding this comment.
why add !kIsWeb in this condition?
There was a problem hiding this comment.
because it is possible that people open the app in browser but on a android or iOs or windows, opening the tab as in 'desktop view'. So, I believed that adding this condition would help.
There was a problem hiding this comment.
I understood the fallacy in my logic. It must show 'tap to start' even if the app were to be opened in a smartphone weather it is browser or mobile app. I shall revise the logic again sir. Thank you for your review.
Shall I make the following changes and pull again?
- remove !kIsWeb in the boolean conditions
- remove options for windows and web, as they are not used in the logic.
- modify the text statement for other platforms to say 'tap/press Space to start' so that users can either tap or press space from a desktop platform.
Description
Added new strings in E:\super_dash\lib\l10n\arb\app_en.arb and modified existing strings.
Earlier, the instructions were 'Tap/press space to start' irrespective of the platform. I modified the existing string 'tapToStart' that says 'Tap/press space to start' into 'Tap to start for the sake of iOs and Android platforms.' I added a new string 'pressSpaceToStart' that says 'Press space to start.' for the sake of desktop platforms.
These changes were made to improve the user experience on different platforms by providing clearer instructions.
Upon making changes, I thoroughly checked how the modified application works in the web browser, on Android, and on iOS.
I also ran 'flutter test --coverage --test-randomize-ordering-seed random', and the modified application passed all tests.
Type of Change
x] ✨ New feature (non-breaking change which adds functionality)