This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
[path_provider] Merge iOS and macOS implementations #6988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested review from
cbracken,
jmagman and
gaaclarke
as code owners
stuartmorgan
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 19, 2023
12 tasks
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* Rename directory; no changes * Exclude new plugin from build-all during the transition * Rename files and classes, update metadata * Make error messages non-macOS-specific * Move implementation to shared location * IGNORE IN REVIEW add symlinks * Add macOS symlink readme * Add iOS support with sharedDarwinSource * Add iOS example freshly created from template * Add iOS symlinks * Add missing library directory to example, for parity with iOS * Move unit test to shared location, and add iOS unit test target using it * Add the Swift search paths to podspec * Remove path_provider_ios * Update CODEOWNERS * Add copyrights to example files
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges
path_provide_iosandpath_provide_macosinto a newpath_provide_foundationsthat replaces both of those packages, as described in flutter/flutter#117941:path_provide_macostopath_provider_foundation, since the macOS implementation is the Swift implementation, which is what we want to use going forward.sharedDarwinSourceto the pubspec, allowing symlink-free support for Fluttermaster), adjusting the code and podspec slightly to make it iOS-compatible (including adding the search paths workaround this time!)flutter create-ing a new iOS example and wiring it up to use the existing native unit test. (This was done instead of moving the example frompath_provider_iossince it seemed better to have the example be in Swift as well now.)path_provider_ios.This incidentally addresses the iOS part of flutter/flutter#93198. While it's unlikely to be a particularly useful path on iOS, the existing macOS implementation works fine on iOS, it's easier to just use it than to explicitly disable it for iOS, and there's no reason I can think of not to support it.
Once this lands and has been published, a follow-up will update
path_providerto use this new package instead of the other two, and the old ones will be marked as deprecated on pub.dev.Most of flutter/flutter#117941
iOS part of flutter/flutter#93198
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.