Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Revert "[ci]Temporarily disable starqlteue on firebase device lab (#6… #6710

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Nov 14, 2022

The starqlteue device is fixed according to Firebase Community Slack channel #test-lab: https://firebase-community.slack.com/archives/C1MTSQ5QT/p1668042163501599?thread_ts=1667399266.906169&cid=C1MTSQ5QT

Fixes flutter/flutter#114535

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@auto-submit
Copy link

auto-submit bot commented Nov 14, 2022

auto label is removed for flutter/plugins, pr: 6710, due to - The status or check suite ios-build_all_plugins CHANNEL:stable has failed. Please fix the issues identified (or deflake) before re-applying this label.

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 14, 2022
@auto-submit
Copy link

auto-submit bot commented Nov 14, 2022

auto label is removed for flutter/plugins, pr: 6710, due to - The status or check suite android-platform_tests CHANNEL:master PACKAGE_SHARDING:--shardIndex 3 --shardCount 5 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@hellohuanlin
Copy link
Contributor

i have the same issue with the submit-queue failure.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Nov 16, 2022

@hellohuanlin Looks like the tree is hanging: https://github.com/flutter/plugins/runs/9538642545 and I don't know how to re-run it. I started a thread in discord: https://discord.com/channels/608014603317936148/608020293944082452/1042576758668537936

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 18, 2022
@cyanglaz cyanglaz merged commit 017e776 into flutter:main Nov 18, 2022
@cyanglaz cyanglaz deleted the revert_6657 branch November 18, 2022 20:37
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 21, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 21, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 21, 2022
* 017e776f9 Revert "[ci]Temporarily disable starqlteue on firebase device lab (#6657)" (flutter/plugins#6710)

* d6c0bcbf2 [ci] Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions) (flutter/plugins#6723)

* 283122b1f Roll Flutter from d2e6dfe to 46d868c (5 revisions) (flutter/plugins#6724)

* 1aabcd62a [camera] Export VideoCaptureOptions so that implementers can use it (flutter/plugins#6666)

* 475caa001 Roll Flutter from 46d868c to 633d7ef (8 revisions) (flutter/plugins#6725)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
…#115761)

* 017e776f9 Revert "[ci]Temporarily disable starqlteue on firebase device lab (flutter#6657)" (flutter/plugins#6710)

* d6c0bcbf2 [ci] Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions) (flutter/plugins#6723)

* 283122b1f Roll Flutter from d2e6dfe to 46d868c (5 revisions) (flutter/plugins#6724)

* 1aabcd62a [camera] Export VideoCaptureOptions so that implementers can use it (flutter/plugins#6666)

* 475caa001 Roll Flutter from 46d868c to 633d7ef (8 revisions) (flutter/plugins#6725)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…#115761)

* 017e776f9 Revert "[ci]Temporarily disable starqlteue on firebase device lab (flutter#6657)" (flutter/plugins#6710)

* d6c0bcbf2 [ci] Manually Roll Flutter from 61e927d to d2e6dfe (143 revisions) (flutter/plugins#6723)

* 283122b1f Roll Flutter from d2e6dfe to 46d868c (5 revisions) (flutter/plugins#6724)

* 1aabcd62a [camera] Export VideoCaptureOptions so that implementers can use it (flutter/plugins#6666)

* 475caa001 Roll Flutter from 46d868c to 633d7ef (8 revisions) (flutter/plugins#6725)
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable starqlteue on firebase test lab for flutter/plugins
3 participants