This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Enable Mac build_all_plugins
#6671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keyonghan
commented
Nov 7, 2022
.ci/targets/build_all_plugins.yaml
Outdated
| @@ -5,3 +5,4 @@ tasks: | |||
| script: .ci/scripts/create_all_plugins_app.sh | |||
| - name: build all_plugins | |||
| script: .ci/scripts/build_all_plugins.sh | |||
| args: ["windows"] | |||
There was a problem hiding this comment.
Didn't find an easy way to inject Env. variable to yaml. It would be nice to consolidate different platforms when recipes has a good support on yaml Env. parser. For now, I am using separate .yaml targets for different platforms.
stuartmorgan
suggested changes
Nov 7, 2022
.ci/scripts/build_all_plugins.sh
Outdated
| cd all_packages | ||
| flutter build windows --debug | ||
| flutter build windows --release | ||
| if [[ "$arg" == "web" ]]; then |
There was a problem hiding this comment.
This is skipping everything on web, rather than just skipping debug.
There was a problem hiding this comment.
Good catch! With changes to the other comment, this is resolved and web case will be handled with a comment for the debug mode.
.ci/scripts/build_all_plugins.sh
Outdated
| echo "Skipping; web does not support debug builds" | ||
| else | ||
| flutter build "$arg" --debug | ||
| flutter build "$arg" --release |
There was a problem hiding this comment.
Although relatedly, I didn't consider this before: in Cirrus I have this as two different script steps because it means that the output for each part is clearly separated in the results UI. That's much more usable than having to scroll through a bunch of output with multiple runs and the failure somewhere in the middle.
I think for LUCI the best option would be to make this take two args, the platform and the build mode, then have the yaml file call it twice, each from a separate task. Then the web logic doesn't need to be here at all, it would just be a comment in a future web_build_all_plugins.yaml about why it's not doing debug like the other platforms.
There was a problem hiding this comment.
Makes sense to me. Updated to accept those two args.
keyonghan
added
the
autosubmit
IVLIVS-III
pushed a commit
to IVLIVS-III/flutter_plugins_fork
that referenced
this pull request
Nov 11, 2022
* general build_all_plugins * add separate macos * add arg for windows * add targets * udpate version file * platform & build_mode args * map docs from cirrus
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2022
* 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)
This was referenced Nov 15, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 21, 2022
* general build_all_plugins * add separate macos * add arg for windows * add targets * udpate version file * platform & build_mode args * map docs from cirrus
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…r#115366) * 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…r#115366) * 79d62f726 Roll Flutter from 5ea5a53 to a1289a4 (7 revisions) (flutter/plugins#6677) * 910b61d1b Roll Flutter from a1289a4 to a1432a9 (23 revisions) (flutter/plugins#6681) * 58579201e Roll Flutter from a1432a9 to d3dcd7d (8 revisions) (flutter/plugins#6684) * 6da73be00 Enable `Mac build_all_plugins` (flutter/plugins#6671) * cc4ffaebd Update flutter cirrus key (flutter/plugins#6687) * f35c16930 Roll Flutter from d3dcd7d to c7d1154 (13 revisions) (flutter/plugins#6689) * 553dac8b2 Roll Flutter from c7d1154 to 098aac7 (24 revisions) (flutter/plugins#6692) * 11cb48366 Roll Flutter (stable) from e99c9c7 to 52b3dc2 (4 revisions) (flutter/plugins#6690) * b1c457fc9 Roll Flutter from 098aac7 to 61e927d (16 revisions) (flutter/plugins#6694) * e500884c7 Enable Mac ios_platform_tests tests (flutter/plugins#6682)
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
* general build_all_plugins * add separate macos * add arg for windows * add targets * udpate version file * platform & build_mode args * map docs from cirrus
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of flutter/flutter#114373.
This PR adds
masterandstableofbuild_all_plugins. Validated using LED runs:master: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/1067548b3015cbda5cebf80785aa167a6ccd86aaf29f052781205547b2854a2d/+/build.protostable: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/f94172b8a04055cc8212499f036b583c9a7125c5e2a378c31e0bb116d3b8225d/+/build.protoAlso confirmed no regression in Windows builders:
master: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/6d3d54408915652d169435a7ec168d35752da188ab6ef48293e82a83a67bdfb3/+/build.protostable: https://luci-milo.appspot.com/raw/build/logs.chromium.org/flutter/led/keyonghan_google.com/3f867b494990fd1f1ecd6785b22ea51d0fa6059f0c01b9cab7b5b2260bbec008/+/build.proto