Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter_web] Use const constructors in the example integration tests #5812

Closed
wants to merge 1 commit into from

Conversation

bparrishMines
Copy link
Contributor

@bparrishMines bparrishMines commented May 23, 2022

No version change: Only updates example integration tests

No CHANGELOG change: Only updates example integration tests

To land: flutter/flutter#104430

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@bparrishMines bparrishMines requested a review from ditman as a code owner May 23, 2022 22:38
@bparrishMines bparrishMines changed the title [google_maps_flutter_web] [google_maps_flutter_web] Use const constructors in the example integration tests May 23, 2022
@jmagman
Copy link
Member

jmagman commented May 23, 2022

I merged #5811 which should cover it. Thanks!

@bparrishMines bparrishMines deleted the maps_const branch May 23, 2022 22:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants