Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add iOS path CODEOWNERS #5306

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Add iOS path CODEOWNERS #5306

merged 1 commit into from
Apr 20, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Apr 19, 2022 •
edited
Loading

Add CODEOWNERS for iOS plugin implementations.
Also fix two incorrect Android paths.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Apr 19, 2022
cyanglaz
cyanglaz approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@cyanglaz cyanglaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

stuartmorgan
stuartmorgan approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching those existing path mistakes too.

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Apr 19, 2022
@fluttergithubbot fluttergithubbot merged commit 1d9f3d3 into flutter:main Apr 20, 2022
@jmagman jmagman deleted the ios-codeowners branch April 20, 2022 17:50
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 21, 2022
@engine-flutter-autoroll
1d9f3d35a Add iOS path CODEOWNERS (flutter/plugins#5306)
3417ee8
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
@jmagman @mauricioluz
Add iOS path CODEOWNERS (flutter#5306)
44299b6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@cyanglaz cyanglaz cyanglaz approved these changes

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees

@jmagman jmagman

Labels
waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmagman @stuartmorgan @cyanglaz @hellohuanlin @fluttergithubbot