Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[google_maps_flutter] Add heatmap support #5274

Closed
wants to merge 120 commits into from

Conversation

Rexios80
Copy link
Member

@Rexios80 Rexios80 commented Apr 14, 2022

Adds heatmap support for web, iOS, and Android

List which issues are fixed by this PR. You must list at least one issue.

#33586
#86811

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Rexios80
Copy link
Member Author

Rexios80 commented Apr 17, 2022

Some notes:

  • All platforms seem to be in a pretty good spot. Android and iOS might need some extra work, but I think it's ready for a preliminary review to make sure the API is how we want it.
  • The CI is complaining about web/index.html not containing the license text. Should this file have it? None of the other generated files seem to have it. Is there a whitelist somewhere?

@Rexios80 Rexios80 marked this pull request as ready for review April 17, 2022 01:40
@Rexios80 Rexios80 requested a review from ditman as a code owner April 17, 2022 01:40
@Rexios80
Copy link
Member Author

I wrote integration tests for iOS and Android. I'm pretty sure web was already taken care of.

],
),
maxIntensity: 1,
// Radius behaves differently on web and Android/iOS.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do the native SDKs document what the units of the radius are supposed to be?

@stuartmorgan
Copy link
Contributor

I forgot to say the new integration test structure looks good, thanks!

@Rexios80
Copy link
Member Author

Not sure why my comments didn't show up all nice like yours, but I added some

@reidbaker reidbaker removed the request for review from GaryQian February 9, 2023 19:30
@stuartmorgan
Copy link
Contributor

We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages.

Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord.

Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants