-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[google_maps_flutter] Add heatmap support #5274
Conversation
Some notes:
|
I wrote integration tests for iOS and Android. I'm pretty sure web was already taken care of. |
packages/google_maps_flutter/google_maps_flutter/example/.metadata
Outdated
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter/example/integration_test/google_maps_test.dart
Outdated
Show resolved
Hide resolved
...ges/google_maps_flutter/google_maps_flutter_android/lib/src/google_maps_flutter_android.dart
Outdated
Show resolved
Hide resolved
], | ||
), | ||
maxIntensity: 1, | ||
// Radius behaves differently on web and Android/iOS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do the native SDKs document what the units of the radius are supposed to be?
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/heatmap.dart
Show resolved
Hide resolved
packages/google_maps_flutter/google_maps_flutter_platform_interface/lib/src/types/heatmap.dart
Outdated
Show resolved
Hide resolved
I forgot to say the new integration test structure looks good, thanks! |
Not sure why my comments didn't show up all nice like yours, but I added some |
We've just completed the migration of the plugin code to the flutter/packages repository, as described in https://flutter.dev/go/flutter-plugins-repo-migration, and this repository is now being archived. Unfortunately that means that all in-progress PRs here must be moved to flutter/packages. Please see our instructions for an explanation of how to move your PR, and if you have any issues moving your PR please don't hesitate to reach out in the #hackers-ecosystem channel in Discord. Our apologies that your PR was caught in this one-time transition. We're aware that it's disruptive in the short term, and appreciate your help in getting us to a better long-term state! |
Adds heatmap support for web, iOS, and Android
List which issues are fixed by this PR. You must list at least one issue.
#33586
#86811
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.