Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[camera_platform_interface] Add web-relevant docs #4358

Conversation

ditman
Copy link
Member

@ditman ditman commented Sep 17, 2021

This PR is the platform_interface part of: #4240.

git cherry-pick 52b8608f61f230ba89ef0e4acbfee0e0f6cce47b
git cherry-pick ad5057472e07df63604489ec344c6a47d2de02a5

It adds information relevant to the web to the platform interface docs.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla

This comment has been minimized.

@google-cla google-cla bot added the cla: no label Sep 17, 2021
@ditman ditman requested review from mvanbeusekom and BeMacized and removed request for bparrishMines September 17, 2021 00:31
@ditman
Copy link
Member Author

ditman commented Sep 17, 2021

@bselwe do you mind approving this PR? It's asking for your permission because I cherry-picked your commit into a branch on my fork, you just need to comment @googlebot I consent.

@mvanbeusekom / @BeMacized do you mind reviewing+landing this? It's a very simple change in the platform_interface docs. In case of any changes required, I think you guys have more "office time" overlap with @bselwe than I do :)

Once this is landed, I'll be able to rebase #4240 one final time, so only the camera example changes need to land!

Thanks everybody!

@google-cla

This comment has been minimized.

@ditman ditman mentioned this pull request Sep 17, 2021
13 tasks
Copy link
Contributor

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once @bselwe gives his consent I will make sure this will land.

@bselwe
Copy link
Contributor

bselwe commented Sep 17, 2021

LGTM! Could we also cherry-pick this commit to include:

/// 2160p (3840x2160 on Android and iOS, 4096x2160 on Web)

@bselwe
Copy link
Contributor

bselwe commented Sep 17, 2021

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 17, 2021
@ditman
Copy link
Member Author

ditman commented Sep 17, 2021

LGTM! Could we also cherry-pick this commit to include:

Arrrrgh, I didn't notice that one! I'll cherry-pick and merge! Thanks @mvanbeusekom!

@ditman ditman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 17, 2021
@mvanbeusekom
Copy link
Contributor

Anytime @ditman

@fluttergithubbot fluttergithubbot merged commit 1e92448 into flutter:master Sep 17, 2021
@ditman ditman deleted the minor-camera-platform-interface-doc-tweaks branch September 17, 2021 22:24
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2021
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes p: camera waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants