-
Notifications
You must be signed in to change notification settings - Fork 9.8k
[camera_platform_interface] Add web-relevant docs #4358
[camera_platform_interface] Add web-relevant docs #4358
Conversation
This comment has been minimized.
This comment has been minimized.
@bselwe do you mind approving this PR? It's asking for your permission because I cherry-picked your commit into a branch on my fork, you just need to comment @mvanbeusekom / @BeMacized do you mind reviewing+landing this? It's a very simple change in the platform_interface docs. In case of any changes required, I think you guys have more "office time" overlap with @bselwe than I do :) Once this is landed, I'll be able to rebase #4240 one final time, so only the Thanks everybody! |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, once @bselwe gives his consent I will make sure this will land.
LGTM! Could we also cherry-pick this commit to include: /// 2160p (3840x2160 on Android and iOS, 4096x2160 on Web) |
@googlebot I consent. |
Arrrrgh, I didn't notice that one! I'll cherry-pick and merge! Thanks @mvanbeusekom! |
Anytime @ditman |
This PR is the platform_interface part of: #4240.
It adds information relevant to the web to the platform interface docs.
Pre-launch Checklist
dart format
.)[shared_preferences]
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.