Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[video_player] Fix a disposed VideoPlayerController throwing an exception when being replaced in the VideoPlayer #4344

Merged
merged 5 commits into from
Sep 15, 2021
Merged

[video_player] Fix a disposed VideoPlayerController throwing an exception when being replaced in the VideoPlayer #4344

merged 5 commits into from
Sep 15, 2021

Conversation

bselwe
Copy link
Contributor

@bselwe bselwe commented Sep 14, 2021 •
edited by ditman
Loading

When switching to a different VideoPlayerController in the VideoPlayer widget, the VideoPlayer.didUpdateWidget method will try to remove its own listener from the previous controller, which by this point has already been disposed.

Fixes flutter/flutter#90046.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Sep 14, 2021
@bselwe
Copy link
Contributor Author

bselwe commented Sep 14, 2021

@ditman @BeMacized

@ditman ditman self-requested a review September 14, 2021 16:24
@google-cla

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 15, 2021
@ditman

This comment has been minimized.

Sign in to view
@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 15, 2021
@ditman
Copy link
Member

ditman commented Sep 15, 2021

Added a test

ditman
ditman approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@ditman ditman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ditman ditman merged commit af758d5 into flutter:master Sep 15, 2021
@ditman ditman deleted the fix/video-player-90046 branch September 15, 2021 23:53
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 18, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2021
@engine-flutter-autoroll
af758d5 [video_player] Fix a disposed VideoPlayerController throwin…
4f16b83 
…g an exception when being replaced in the `VideoPlayer` (flutter/plugins#4344)
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@bselwe @ditman @amantoux
[video_player] Fix a disposed VideoPlayerController throwing an exc…
d2ab05e 
…eption when being replaced in the `VideoPlayer` (flutter#4344)

* fix: do not removeListener if VideoPlayerController is already disposed

Co-authored-by: David Iglesias Teixeira <[email protected]>
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@bselwe @ditman @KyleFin
[video_player] Fix a disposed VideoPlayerController throwing an exc…
af83b92 
…eption when being replaced in the `VideoPlayer` (flutter#4344)

* fix: do not removeListener if VideoPlayerController is already disposed

Co-authored-by: David Iglesias Teixeira <[email protected]>
@huycozy huycozy mentioned this pull request May 19, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ditman ditman ditman approved these changes

Assignees
No one assigned
Labels
cla: yes p: video_player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[video_player] A disposed VideoPlayerController throws an exception when being replaced in the VideoPlayer
2 participants
@bselwe @ditman