Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[image_picker] Bump minimum Flutter version and iOS deployment target #4335

Merged
merged 1 commit into from
Sep 17, 2021
Merged

[image_picker] Bump minimum Flutter version and iOS deployment target #4335

merged 1 commit into from
Sep 17, 2021

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Sep 11, 2021

Flutter apps run on 2.4.0-0.0.pre and later will be upgraded to a minimum of iOS 9.0. Now that Flutter 2.5 has hit stable and iOS 8 support has been dropped, change the plugin minimum iOS version to 9.0.

Bump the Flutter and dart version constraints to 2.5 and 2.14 respectively to enforce that the iOS 9.0 migration has happened on the app side, because an older 8.0 app won't build with a 9.0 plugin. I believe the last time this was done was a few months ago for null safety adoption #3324 (there's recent precedent).

Users on Flutter versions lower than the current stable 2.5 will not be able to upgrade this plugin past this version.

image_picker part of flutter/flutter#84198

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [relevant style guides] and ran [the auto-formatter]. (Note that unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the [CLA].
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • All existing and new tests are passing.

@jmagman jmagman self-assigned this Sep 11, 2021
@jmagman jmagman requested a review from cyanglaz as a code owner September 11, 2021 01:05
@google-cla google-cla bot added the cla: yes label Sep 11, 2021
jmagman
jmagman commented Sep 11, 2021
View reviewed changes
packages/image_picker/image_picker/example/ios/Runner.xcodeproj/project.pbxproj
@@ -684,7 +684,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
IPHONEOS_DEPLOYMENT_TARGET = 9.0;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same, done automatically via flutter/flutter#85174.

packages/image_picker/image_picker/example/ios/Flutter/AppFrameworkInfo.plist
@@ -25,6 +25,6 @@
<string>arm64</string>
</array>
<key>MinimumOSVersion</key>
<string>8.0</string>
<string>9.0</string>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done automatically via flutter/flutter#85174 by just flutter building the example project.

cyanglaz
cyanglaz reviewed Sep 11, 2021
View reviewed changes
packages/image_picker/image_picker/pubspec.yaml Outdated
@@ -3,11 +3,11 @@ description: Flutter plugin for selecting images from the Android and iOS image
library, and taking new pictures with the camera.
repository: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+image_picker%22
version: 0.8.4
version: 0.8.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to the google map PR, 0.8.4+1 is probably enough.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

stuartmorgan
stuartmorgan approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@stuartmorgan stuartmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land. label Sep 17, 2021
@fluttergithubbot fluttergithubbot merged commit 701fdb6 into flutter:master Sep 17, 2021
@jmagman jmagman deleted the ip-9 branch September 17, 2021 02:39
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 18, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 18, 2021
@engine-flutter-autoroll
701fdb6 [image_picker] Bump minimum Flutter version and iOS deploymen…
26c0ab5 
…t target (flutter/plugins#4335)
@nguyenlamzx
Copy link

nguyenlamzx commented Sep 22, 2021 •
edited
Loading

@jmagman can we keep the previous sdk constrains? because there're many packages didn't update to sdk and I using this package along with other packages.

For now, I use old version image_picker: 0.8.4+1 to be able to install successfully

@jmagman
Copy link
Member Author

jmagman commented Sep 22, 2021

@jmagman can we keep the previous sdk constrains? because there're many packages didn't update to sdk and I using this package along with other packages.

For now, I use old version image_picker: 0.8.4+1 to be able to install successfully

From 701fdb6#r56918265

Flutter 2.5 shipped with Dart 2.14, so that's the minimum of the range. You can see in flutter/flutter#84198 why we wanted to target 2.5, namely we need to make sure all consumers of the plugin have upgraded their apps to iOS 9 or later before this plugin could drop support for iOS 8.
If you're seeing an issue related to this bump, please file a new issue so the ecosystem team can evaluate this strategy.

Or you can comment on flutter/flutter#84198

@jmagman jmagman mentioned this pull request Sep 22, 2021
Closed
amantoux pushed a commit to amantoux/plugins that referenced this pull request Sep 27, 2021
@jmagman @amantoux
[image_picker] Bump minimum Flutter version and iOS deployment target (…
b9ddefe 
…flutter#4335)
KyleFin pushed a commit to KyleFin/plugins that referenced this pull request Dec 21, 2021
@jmagman @KyleFin
[image_picker] Bump minimum Flutter version and iOS deployment target (…
bdadbd1 
…flutter#4335)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cyanglaz cyanglaz cyanglaz left review comments

@stuartmorgan stuartmorgan stuartmorgan approved these changes

Assignees

@jmagman jmagman

Labels
cla: yes p: image_picker platform-ios waiting for tree to go green (Use "autosubmit") This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmagman @nguyenlamzx @stuartmorgan @cyanglaz @fluttergithubbot