Add implements value to the pubspec #3577
Conversation
|
@stuartmorgan I added some TODOs. would you mind checking that this is what you expect? (I'm not familiar with the Desktop plugins) |
|
These could also be part of stable releases for those plugin to avoid 1 additional publish. |
| @@ -1,3 +1,8 @@ | |||
| ## 2.0.0-nullsafety.1 | |||
There was a problem hiding this comment.
You'll need to do an actual point release for this since they already landed.
packages/path_provider/path_provider_windows/lib/src/path_provider_windows_real.dart
Outdated
Show resolved
Hide resolved
|
@stuartmorgan PTAL |
packages/shared_preferences/shared_preferences_linux/lib/shared_preferences_linux.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_windows/lib/shared_preferences_windows.dart
Outdated
Show resolved
Hide resolved
blasten
force-pushed
the
add_implements
branch
from
091b88f to
f98ac67
Compare
|
Due to transitive dependencies, I would need to merge this PR on red, and republish the packages, bump dependencies, and rerun the checks. |
packages/package_info/pubspec.yaml
Outdated
|
|
||
| flutter: | ||
| plugin: | ||
| implements: package_info |
There was a problem hiding this comment.
package_info implements package_info? I thought implements was only for federated plugins.
There was a problem hiding this comment.
default_package is more appropriate here. The schema validator found macos platform, but no implements:, nor default_package: value. Done
...d_preferences/shared_preferences_linux/example/integration_test/shared_preferences_test.dart
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_linux/example/lib/main.dart
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
blasten
force-pushed
the
add_implements
branch
7 times, most recently
from
2de65de to
9386423
Compare
blasten
force-pushed
the
add_implements
branch
from
9386423 to
1fe6814
Compare
|
This PR is blocked until the tools changes land in stable. |
|
Do you want to break this apart into a couple of PRs? You could just add |
|
sgtm |
|
@stuartmorgan This PR won't be able to land until the next stable because it would break users using these plugins and Flutter stable. |
|
What's changed since the discussion above (#3577 (comment)) about being able to land part of this now? |
|
Primarily, I was looking at the shim https://github.com/flutter/plugins/pull/3577/files#diff-0a54019786f62bf41f0c6d1481397f36d46d3a18abbead0d0467d2e0acdeeb1dL30, and thought it would conflict, but now I realize that it checks if Sgtm |
|
Now that 2.5 has shipped I believe this could be updated (implements has been added, but the registration workarounds still need to be removed) and landed. |
|
@blasten Do you want to merge in master here and see if this is ready to land? |
|
I did the registration removal in separate PRs (one landed, one outstanding) so this is obsolete. |
Fixes flutter/flutter#76396