Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[path_provider_linux] Migrate to nnbd #3486

Closed

Conversation

gaetschwartz
Copy link
Contributor

Migrating path_provider_linux to null-safety. Needed to migrate shared_preferences.

It contributes to fixing flutter/flutter#74876.

Pre-launch Checklist

  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaetschwartz
Copy link
Contributor Author

gaetschwartz commented Jan 30, 2021

I'm unsure as to why the CI is failing, it's related to path_provider_windows, which I didn't touch.

@stuartmorgan
Copy link
Contributor

There's an existing PR for this at #3330; please comment there if you have changes to suggest.

@gaetschwartz
Copy link
Contributor Author

@stuartmorgan What is wrong with the other PR ? It's currently blocking the migration of shared_preferences, one of the most used package of this repo. Getting it reviewed would help a lot :)

@gaetschwartz gaetschwartz deleted the path_provider_linux_nnbd branch January 30, 2021 19:28
@stuartmorgan
Copy link
Contributor

@stuartmorgan What is wrong with the other PR ?

I'm not sure what you are asking here. Why do you think something is wrong with it?

It's currently blocking the migration of shared_preferences, one of the most used package of this repo. Getting it reviewed would help a lot :)

I expect to review it next week. It's only actually been reviewable for about a day, since a core dependency hadn't been migrated.

@gaetschwartz
Copy link
Contributor Author

@stuartmorgan Alright, was just wondering why it hadn't been reviewed. Missed the part where it needed a code dependency 😊 Sorry if it sounded weird, wasn't the point 💙☺️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants