Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Use Xvfb for Linux desktop tests #2750

Merged
merged 2 commits into from
May 12, 2020

Conversation

stuartmorgan
Copy link
Contributor

@stuartmorgan stuartmorgan commented May 11, 2020

Description

Flutter plugin tests don't necessarily run in headless mode; this adds a virtual display when running Linux tests so that they will run in normal mode.

Related Issues

Fixes flutter/flutter#55327

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@stuartmorgan stuartmorgan changed the title [WIP] Use Xvfb for Linux desktop tests Use Xvfb for Linux desktop tests May 11, 2020
@stuartmorgan stuartmorgan removed the WIP label May 11, 2020
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much to review here but it's logical to run the tests inside an X server.

Note that 'apt-get' was replaced by 'apt' in Ubuntu 16.04. I'm not sure what Linux image the CI is using but you could probably update these commands.

@stuartmorgan stuartmorgan merged commit 4603cac into flutter:master May 12, 2020
@stuartmorgan stuartmorgan deleted the linux-desktop-xvfb branch May 12, 2020 17:10
mgonzalezc pushed a commit to mgonzalezc/plugins that referenced this pull request May 19, 2020
* master: (96 commits)
  Update README.md (flutter#2768)
  [url_launcher_web] Launch mailto urls in same window in Safari (flutter#2740)
  update README with enableJavaScript info (flutter#2766)
  Run publish ci check on master (flutter#2764)
  [image_picker] Add documentation for Android external storage permissions (flutter#2765)
  [package_info] add support for macos to package_info plugin (flutter#2618)
  fixed detach from engine logic (flutter#2759)
  [url_launcher] Initialize previousAutomaticSystemUiAdjustment in launch (flutter#2757)
  [google_maps_flutter] add todo on skipped test. (flutter#2752)
  [google_maps_flutter] use `WaitUntilTouchesEndedPolicy` to fix the cameraIdle not called issue on iOS (flutter#2746)
  Use Xvfb for Linux desktop tests (flutter#2750)
  update lower dart bound to 2.1.0 (flutter#2751)
  [camera] Update lower bound of dart dependency to 2.1.0. (flutter#2749)
  [battery] update dart deps lower bound to 2.1.0 (flutter#2748)
  [android_alarm_manager] update dart deps lower bound to 2.1.0 (flutter#2747)
  [url_launcher] Add web to example app. (flutter#2736)
  [in_app_purchase] update docs to warn about `completePurchase` (flutter#2739)
  [video_player] upgraded video_player to use pigeon (flutter#2544)
  [video_player]: fixed platform_interface unit tests (flutter#2745)
  [video_player]: added test class to fix video_player unit tests (flutter#2744)
  ...

# Conflicts:
#	packages/quick_actions/ios/Classes/FLTQuickActionsPlugin.m
EdwinRomelta pushed a commit to EdwinRomelta/plugins that referenced this pull request Jun 11, 2020
Flutter plugin tests don't necessarily run in headless mode; this adds a virtual display when running Linux tests so that they will run in normal mode.

Fixes flutter/flutter#55327
jorgefspereira pushed a commit to jorgefspereira/plugins_flutter that referenced this pull request Oct 10, 2020
Flutter plugin tests don't necessarily run in headless mode; this adds a virtual display when running Linux tests so that they will run in normal mode.

Fixes flutter/flutter#55327
FlutterSu pushed a commit to FlutterSu/flutter-plugins that referenced this pull request Nov 20, 2020
Flutter plugin tests don't necessarily run in headless mode; this adds a virtual display when running Linux tests so that they will run in normal mode.

Fixes flutter/flutter#55327
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e testing support for Linux in flutter/plugins
3 participants