This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Migrate away from deprecated BinaryMessages
#2444
Merged
harryterkelsen
merged 4 commits into
flutter:master
from
harryterkelsen:update-binary-messenger
Jan 3, 2020
Merged
Migrate away from deprecated BinaryMessages
#2444
harryterkelsen
merged 4 commits into
flutter:master
from
harryterkelsen:update-binary-messenger
Jan 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirh
approved these changes
Jan 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo making it patch version bumps
packages/connectivity/pubspec.yaml
Outdated
@@ -2,7 +2,7 @@ name: connectivity | |||
description: Flutter plugin for discovering the state of the network (WiFi & | |||
mobile/cellular) connectivity on Android and iOS. | |||
homepage: https://github.com/flutter/plugins/tree/master/packages/connectivity | |||
version: 0.4.6+1 | |||
version: 0.4.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be a patch bump, no new feature is introduced.
packages/sensors/pubspec.yaml
Outdated
@@ -2,7 +2,7 @@ name: sensors | |||
description: Flutter plugin for accessing the Android and iOS accelerometer and | |||
gyroscope sensors. | |||
homepage: https://github.com/flutter/plugins/tree/master/packages/sensors | |||
version: 0.4.1+5 | |||
version: 0.4.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
patch bump
@@ -1,6 +1,6 @@ | |||
name: webview_flutter | |||
description: A Flutter plugin that provides a WebView widget on Android and iOS. | |||
version: 0.3.19+1 | |||
version: 0.3.20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
hjc22
pushed a commit
to hjc22/plugins
that referenced
this pull request
Jan 8, 2020
…acheing-01-08 * flutterPlugin/master: (30 commits) Update Gradle version (flutter#2448) [image_picker] support android V2 embedding (flutter#2430) [webview_flutter] Setup XCTests (flutter#2445) [video_player] Fixes video initialization future stall. (flutter#2134) [ci] Upgrade to Xcode 11.3 (flutter#2435) [In_app_purchases] migrate to Play Billing Library 2.0. (flutter#2287) Migrate away from deprecated `BinaryMessages` (flutter#2444) [google_sign_in]Update google_sign_in_example name in pubspec.yaml (flutter#2335) [ios_platform_images] Removed android support from the pubspec. (flutter#2432) [google_sign_in] Expose network error (flutter#2398) [battery] cleanup for Android embedding post 1.12 (flutter#2400) [flutter_webview] Raise min Flutter SDK to stable (flutter#2425) re-enable stable CI (flutter#2402) [in_app_purchase]Change a comment. (flutter#2329) [google_sign_in] Pass the client id to the platform interface. (flutter#2427) [ios_platform_images] Made ios_platform_images set the correct image scale. (flutter#2414) [url_launcher_platform_interface] use non static token for platform interface (flutter#2418) [plugin_platform_interface] Don't use const Object as a token (flutter#2417) Update endorsed macos plugins readme and update others (flutter#2407) [webview_flutter] add gesture navigation for iOS (flutter#2339) ... # Conflicts: # packages/video_player/video_player/CHANGELOG.md # packages/video_player/video_player/pubspec.yaml
FlutterSu
pushed a commit
to FlutterSu/flutter-plugins
that referenced
this pull request
Nov 20, 2020
* BinaryMessages migration for package:connectivity * Migrate package:sensors from deprecated BinaryMessages * Migrate package:webview_flutter from deprecated BinaryMessages * Only do patch bumps
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migrate away from the deprecated
BinaryMessages
to its supported replacement,ServicesBinding.instance.defaultBinaryMessenger
.Related Issues
Fixes flutter/flutter#33446
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.///
).flutter analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?